Skip to content

#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 26, 2025
Merged

#2382: ccm-lb: add backoff to avoid performance issues w/locking #2383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e0693f2
#2382: ccm-lb: add backoff to avoid performance issues w/locking
lifflander Dec 18, 2024
7a23a82
#2382: ccm-lb: add max iter time and cycle lock count
lifflander Dec 19, 2024
333825f
#2382: ccm-lb: fix bug
lifflander Dec 19, 2024
3b85066
#2382: ccm-lb: fix iter time so it's not additive
lifflander Dec 19, 2024
222a612
#2382: ccm-lb: implement incremental update for cluster summaries
lifflander Dec 23, 2024
521b323
#2382: ccm-lb: fix some compile-time issues
lifflander Dec 23, 2024
6225658
#2382: ccm-lb: stop adding cluster when load is zero (empty cluster)
lifflander Dec 23, 2024
af9cb2b
#2382: ccm-lb: another optimization
lifflander Dec 23, 2024
e5eea4e
#2382: ccm-lb: reduce sleep to 100us
lifflander Dec 23, 2024
52be5b4
#2382: scripts: try to factor out task/communication schema code
lifflander Feb 25, 2025
36d2466
#2382: temperedlb: remove commented code
lifflander Feb 25, 2025
7f2f5b0
#2382: temperedlb: explain 100 microsecond delay when a lock cycle is…
lifflander Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 54 additions & 96 deletions scripts/LBDatafile_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,56 @@ def validate_ids(field):

return field

task = {
'entity': And({
Optional('collection_id'): int,
'home': int,
Optional('id'): int,
Optional('seq_id'): int,
Optional('index'): [int],
'type': str,
'migratable': bool,
Optional('objgroup_id'): int
}, validate_ids),
'node': int,
'resource': str,
Optional('subphases'): [
{
'id': int,
'time': float,
}
],
'time': float,
Optional('user_defined'): dict,
Optional('attributes'): dict
}

communication = {
'type': str,
'to': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'messages': int,
'from': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'bytes': float
}

LBDatafile_schema = Schema(
{
Optional('type'): And(str, "LBDatafile", error="'LBDatafile' must be chosen."),
Expand Down Expand Up @@ -42,112 +92,20 @@ def validate_ids(field):
{
'id': int,
'tasks': [
{
'entity': And({
Optional('collection_id'): int,
'home': int,
Optional('id'): int,
Optional('seq_id'): int,
Optional('index'): [int],
'type': str,
'migratable': bool,
Optional('objgroup_id'): int
}, validate_ids),
'node': int,
'resource': str,
Optional('subphases'): [
{
'id': int,
'time': float,
}
],
'time': float,
Optional('user_defined'): dict,
Optional('attributes'): dict
},
task
],
Optional('communications'): [
{
'type': str,
'to': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'messages': int,
'from': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'bytes': float
}
communication
],
Optional('user_defined'): dict,
Optional('lb_iterations'): [
{
'id': int,
'tasks': [
{
'entity': And({
Optional('collection_id'): int,
'home': int,
Optional('id'): int,
Optional('seq_id'): int,
Optional('index'): [int],
'type': str,
'migratable': bool,
Optional('objgroup_id'): int
}, validate_ids),
'node': int,
'resource': str,
Optional('subphases'): [
{
'id': int,
'time': float,
}
],
'time': float,
Optional('user_defined'): dict,
Optional('attributes'): dict
},
task
],
Optional('communications'): [
{
'type': str,
'to': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'messages': int,
'from': And({
'type': str,
Optional('id'): int,
Optional('seq_id'): int,
Optional('home'): int,
Optional('collection_id'): int,
Optional('migratable'): bool,
Optional('index'): [int],
Optional('objgroup_id'): int,
}, validate_ids),
'bytes': float
}
communication
],
Optional('user_defined'): dict
}
Expand Down
Loading