Skip to content

Avoid server error in FlexibleImageWidget validation #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koopmant merged 5 commits into from
Oct 28, 2025
Merged

Avoid server error in FlexibleImageWidget validation #4381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d3ba23
Clean up algorithms test_forms
koopmant Oct 24, 2025
8f729e8
Clean up cases test_widget
koopmant Oct 24, 2025
2194033
Add tests to catch error
koopmant Oct 24, 2025
b768a64
Fix the bug
koopmant Oct 24, 2025
8cec4b2
Raise error if value is falsy
koopmant Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/grandchallenge/cases/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,17 @@ def __init__(
)
super().__init__(widgets, attrs)

def decompress(self, value):
def decompress(self, value): # noqa: C901
if not value:
return [None, None]

if isinstance(value, (list, tuple)):
if len(value) == 1:
item = value[0]
if item == "":
return [None, None]
if not item:
raise RuntimeError("Unexpected value")
Comment thread
koopmant marked this conversation as resolved.
if item in ImageWidgetChoices.names:
return [None, None]
if Image.objects.filter(pk=item).exists():
Expand Down
Loading