Skip to content

Enable more phases for budget 1: Add and deprecate fields#4502

Merged
koopmant merged 2 commits into
enable-more-phases-for-budgetfrom
enable-more-phases-for-budget-1
Jan 20, 2026
Merged

Enable more phases for budget 1: Add and deprecate fields#4502
koopmant merged 2 commits into
enable-more-phases-for-budgetfrom
enable-more-phases-for-budget-1

Conversation

@koopmant
Copy link
Copy Markdown
Contributor

@koopmant koopmant commented Jan 9, 2026

No description provided.

@koopmant koopmant requested a review from jmsmkn as a code owner January 9, 2026 11:28
@koopmant koopmant force-pushed the enable-more-phases-for-budget-1 branch from 4f1ea6a to 25e972c Compare January 9, 2026 11:36
chrisvanrun
chrisvanrun approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@chrisvanrun chrisvanrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am wondering what will happen with the deprecated fields in the follow up PRs =)

@koopmant
Copy link
Copy Markdown
Contributor Author

koopmant commented Jan 20, 2026

I am wondering what will happen with the deprecated fields in the follow up PRs =)

Haha. I have a PR standby to clean them up. But that will have to be done in a separate deployment, so for now they'll have to stay.

@koopmant koopmant merged commit d0c9eec into enable-more-phases-for-budget Jan 20, 2026
8 of 12 checks passed
@koopmant koopmant deleted the enable-more-phases-for-budget-1 branch January 20, 2026 10:46
@chrisvanrun
Copy link
Copy Markdown
Member

chrisvanrun commented Jan 20, 2026

I am wondering what will happen with the deprecated fields in the follow up PRs =)

Haha. I have a PR standby to clean them up. But that will have to be done in a separate deployment, so for now they'll have to stay.

Is it unwise to pack it in a single deployment, or just not possible?

@koopmant
Copy link
Copy Markdown
Contributor Author

koopmant commented Jan 20, 2026

Is it unwise to pack it in a single deployment, or just not possible?

It's not possible because during deployment we have two instances running at the same time, the old one and the new one. James explained it to me here.

koopmant added a commit that referenced this pull request Feb 10, 2026
@koopmant
Add and deprecate fields (#4502)
26a8176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisvanrun chrisvanrun chrisvanrun approved these changes

@jmsmkn jmsmkn Awaiting requested review from jmsmkn

Assignees

@koopmant koopmant

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koopmant @chrisvanrun