feat(OGC-1054): add safe Analyzer Type mapping - #4118
Open
pmanko wants to merge 96 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9bb30a7e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…' into codex/ogc-1054-m2-mapping
…2-mapping # Conflicts: # frontend/src/App.jsx
…2-mapping # Conflicts: # tools/openelis-analyzer-bridge
…2-mapping # Conflicts: # tools/openelis-analyzer-bridge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deliver OE-M2, the OpenELIS half of the OGC-1054 safe mapping checkpoint. Add
one reusable Analyzer Type mapping editor, catalog-safe test/result bindings,
auditable confirmation, and complete removal of superseded per-analyzer mapping
and classifier paths.
Scope
per-analyzer editor remains
match state, catalog selection, and explicit exclusion where allowed
Test; value and label are derived server-side and survive reload
recognition with actor, time, row IDs, revision, and fingerprints
shared revision or binding change
movement
AnalyzerQcRuleruntime, schema, payload, readiness, and UI pathrestoring an OpenELIS analyzer classifier or a narrow competing “MVP” label
Stack
pinned by the ordinary Bridge submodule at
d826d6ac3eb55c63c3b74649facfdf3b2c6e87b1Strict order is BR-M2 -> OE-M2. On publication, the roadmap moves M2 to
[x]and M3 to the sole
[*]checkpoint.TDD evidence
Service, persistence, migration, consumer-contract, removal-guard, RTL/router,
and UI-story behavior was introduced in red-green commits. The final
specification guard first failed on the obsolete per-analyzer QC story and then
passed after the source specification, plan, and tasks were amended.
Validation
confirmation timestamp inspected; no application console errors
mvn spotless:check, full Prettier check, lint, production build, and bothPlaywright guards: passed
mvn verify: 632 passed, 3 skippedopenelis-work@mainvisual baseline refreshed at5fc8963b; implementationpreserves the mapping hierarchy and result-choice intent and remains usable on
mobile where the prototype itself overflows beside its fixed sidebar
Known inherited gates
OE-M1. M2 introduces no errors in its new files and removes the obsolete Copy
Mappings declaration error; this PR does not claim that global gate is green.
logs caught null errors while passing. M3 linked operational-QC acceptance
must correct and strengthen that fixture before claiming clean QC evidence.
Architecture guard
Bridge remains the profile and analyzer-runtime owner. OpenELIS owns local
clinical bindings, verification/audit, activation, and separate operational QC.
There is no copied profile authority, per-analyzer mapping override,
AnalyzerQcRule,QcRun, hidden classifier fallback, dual writer, duplicatequeue, or OpenELIS FILE poller.