Conversation
As this is a new feature
Because GitHub actions approval button is missing
This reverts commit f5f2ca2. we can revert the yarn changes and do it in a different PR
Also, fish bit was the only one that didn't print a newline to $CONF_FILE, now they're all the same.
Change $CONF_FILE append strings to check whether $INSTALL_DIR exists before doing any setup. This way whenever a user syncs their shell config across machines, the machines without fnm installed won't throw errors.
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
* feat: support to install the latest version * chore: test & fmt & clippy * docs: update command docs * docs: update command docs * Create warm-rice-appear.md * Update change set to be a minor release As this is a new feature * chore: update workflow to install pnpm * Remove `feat:` from changeset Because GitHub actions approval button is missing * run pnpm like other tasks * Revert "run pnpm like other tasks" This reverts commit f5f2ca2. we can revert the yarn changes and do it in a different PR * revert the changes in .github/workflows * feat: add remote version sorting and filtering * use `UserVersion` for filtering * add additional lts filter * refactor: use `Vec::retain` instead of filtering and collecting * fix docstring for sort option * change docstring for filter argument * refactor vec filtering Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> * refactor to use `sort_by_key` and `reverse` Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> * add latest flag * make filter an option as well * move sort into command as it is presentational * fix getting latest version * refactors * update docs/commands.md * sort upon installation * fix clippy * don't mention rust structs in the cli docs * test more stuff in archiving * fnm env --global: considering if this is a good idea technically i think that i can just mutate the 'default' alias instead. because now that i think about it, it makes 0 sense to set current to 'default' every time a new shell is opened. so current _is_ default. * chore(deps): update rust crate embed-resource to v2.5.2 * fix(deps): update rust crate tar to v0.4.44 * fix(deps): update rust crate thiserror to v1.0.69 * chore(deps): update clap-rs * chore(deps): update rust crate chrono to v0.4.44 * chore(deps): update all dev dependencies --------- Co-authored-by: Fred <nzhlfred@gmail.com> Co-authored-by: Gal Schlezinger <gal@spitfire.co.il> Co-authored-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com> Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…dates (#146) Bumps the npm_and_yarn group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) | `7.26.0` | `7.28.6` | | [brace-expansion](https://github.com/juliangruber/brace-expansion) | `1.1.11` | `1.1.12` | | [js-yaml](https://github.com/nodeca/js-yaml) | `3.14.1` | `3.14.2` | | [lodash](https://github.com/lodash/lodash) | `4.17.21` | `4.17.23` | | [minimatch](https://github.com/isaacs/minimatch) | `3.1.2` | `3.1.5` | Updates `@babel/helpers` from 7.26.0 to 7.28.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.28.6/packages/babel-helpers) Updates `brace-expansion` from 1.1.11 to 1.1.12 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) Updates `lodash` from 4.17.21 to 4.17.23 - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) Updates `minimatch` from 3.1.2 to 3.1.5 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.5) --- updated-dependencies: - dependency-name: "@babel/helpers" dependency-version: 7.28.6 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@Mergifyio update |
☑️ Nothing to do, the required conditions are not metDetails
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a powerful new hooks system for Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a wide range of changes, including dependency updates, CI configuration changes, documentation improvements, and significant refactoring of the Rust source code. Key improvements include making the installation script more portable and robust, adding support for hooks, and refactoring the archive extraction and version parsing logic.
I've found a couple of issues: one is a bug in the ls-remote command logic, and the other is a redundancy in the new CircleCI configuration. My review includes suggestions to fix these. Overall, the changes are positive and improve the project's quality.
7 participants
No description provided.