NovaCustom MiniPC #643
NovaCustom MiniPC #643
Conversation
|
If we're gonna copy code from somewhere, please give proper attribution at least in the commit message |
| @@ -0,0 +1,36 @@ | |||
| /* SPDX-License-Identifier: GPL-2.0-only */ | |||
|
|
|||
| //TODO: HACK FOR MISSING MISCCFG_GPIO_PM_CONFIG_BITS | |||
There was a problem hiding this comment.
this entire file should be removed
filipleple
force-pushed
the
nvc_nuc_box
branch
3 times, most recently
from
de62d98 to
e200626
Compare
filipleple
force-pushed
the
nvc_nuc_box
branch
2 times, most recently
from
6c84ea8 to
399a1d6
Compare
filipleple
force-pushed
the
nvc_nuc_box
branch
2 times, most recently
from
2981017 to
5e20dd4
Compare
filipleple
force-pushed
the
nvc_nuc_box
branch
3 times, most recently
from
b89afde to
5ab02d9
Compare
This is a copy of the System76 Meer9 code, which is an initial port of the ASROCK NUC BOX hardware. This platform is also based on that hardware. Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
force-pushed
the
nvc_nuc_box
branch
2 times, most recently
from
767ab74 to
fad1483
Compare
Signed-off-by: Filip Lewiński <[email protected]>
This reverts commit 692b501.
This reverts commit 64fa3c2.
This reverts commit 7a9385f.
This reverts commit 79fb20e.
Signed-off-by: Filip Lewiński <[email protected]>
… lock Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
…ot ready Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
|
|
||
| static void mainboard_init(void *chip_info) | ||
| { | ||
| mainboard_configure_gpios(); |
There was a problem hiding this comment.
This is too late. At this point the FSP will be long done. If we program GPIOS that late, FSP may fail to initialize certain IP blocks. It should happen before FSP-M ideally.
|
|
||
| // XXX: Enabling C10 reporting causes system to constantly enter and | ||
| // exit opportunistic suspend when idle. | ||
| params->PchEspiHostC10ReportEnable = 0; |
There was a problem hiding this comment.
if D3COLD_SUPPORT is set to disabled, then no opportunistic suspend will happen. It seems to be broken board code all along...
This option and D3COLD_SUPPORT should be enabled for opportunistic suspend to work...
| const bool half_populated = false; | ||
|
|
||
| mupd->FspmConfig.DmiMaxLinkSpeed = 4; | ||
| mupd->FspmConfig.GpioOverride = 0; |
There was a problem hiding this comment.
This should not be cleared. By default coreboot ste's it to 1, so that FSP will not override coreboot programmed GPIOs.
Remove it and initialize GPIOs before FSP-M. Then some problems will possibly go away.
Signed-off-by: Filip Lewiński <[email protected]>
…ole region Signed-off-by: Filip Lewiński <[email protected]>
There was a problem hiding this comment.
Why not reuse FSP and GOP driver from the MTL laptops?
There was a problem hiding this comment.
Will try with the FSP, the laptop GOP driver doesn't work - it somehow alters the VBT (I've compared what ends up loaded by Ubuntu to what's in the repo) making the HDMI ports not work.
There was a problem hiding this comment.
VBT is always altered when seen by OS. VBT is a part of operation region that is used for communicating with graphics. You can't expect to have the same VBT after intiialization, as it is supposed to be patched runtime.
Also I don;t see a reason to use EFI GOP driver at all. FSP GOP should be sufficient in the first place. We used EFI GOP in laptops because of high DPI panel. The NUC BOX does not have internal LCD panel
No description provided.