Wrap ContainerTagsHash around !NETFRAMEWORK by bouwkast · Pull Request #8363 · DataDog/dd-trace-dotnet

bouwkast · 2026-03-24T19:11:36Z

Summary of changes

It appears that this isn't supposed to be set on .NET Framework and we have a Log.Error for whenever ContainerTagsHash is set.

This was intended from what I can tell to be to see if customers were setting this while on .NET Framework, but we set it ourselves on .NET Framework in DiscoveryService

Reason for change

Identified by Error Tracking with a large number of errors from the latest release, realistically these are harmless errors and were supposed to indicate to customers that this functionality isn't available on .NET Framework, but instead we are the ones calling it.

Implementation details

Added !NETFRAMEWORK

Test coverage

Used Visual Studio and did a Find all References on it, I think this is it😅

Other details

Fixes APMLP-1140

It appears that this isn't supposed to be set on .NET Framework and we have a Log.Error for whenever ContainerTagsHash is set. This was intended from what I can tell to be to see if customers were setting this while on .NET Framework, but we set it ourselves on .NET Framework in DiscoveryService

pr-commenter · 2026-03-24T19:56:41Z

Benchmarks

Benchmark execution time: 2026-03-24 21:49:56

Comparing candidate commit 2893a40 in PR branch steven/the-code-fix with baseline commit 1bb5b79 in branch master.

Found 9 performance improvements and 9 performance regressions! Performance is the same for 256 metrics, 14 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟩 execution_time [-22.041ms; -21.970ms] or [-17.732%; -17.675%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟩 execution_time [-91.875ms; -91.688ms] or [-45.485%; -45.393%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

🟩 execution_time [-17.760ms; -13.157ms] or [-7.669%; -5.681%]
🟩 throughput [+62.877op/s; +84.663op/s] or [+6.065%; +8.167%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟥 throughput [-167.195op/s; -81.831op/s] or [-10.429%; -5.105%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟩 execution_time [-18.399ms; -12.314ms] or [-11.676%; -7.814%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

🟥 execution_time [+92.336µs; +98.598µs] or [+6.646%; +7.097%]
🟥 throughput [-47.869op/s; -44.701op/s] or [-6.651%; -6.210%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

🟩 execution_time [-888.137µs; -647.415µs] or [-32.080%; -23.385%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

🟥 execution_time [+128.259µs; +133.674µs] or [+5.024%; +5.237%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

🟥 execution_time [+11.528ms; +13.877ms] or [+5.778%; +6.955%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

🟥 throughput [-52427.998op/s; -42704.211op/s] or [-8.072%; -6.575%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

🟥 allocated_mem [+17.715KB; +17.744KB] or [+6.882%; +6.893%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

🟩 execution_time [-28.905ms; -27.849ms] or [-14.457%; -13.929%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

🟥 execution_time [+111.226ms; +112.923ms] or [+127.421%; +129.366%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

🟥 throughput [-16450727.031op/s; -15554615.710op/s] or [-6.816%; -6.444%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

🟩 execution_time [-22.618ms; -17.399ms] or [-10.339%; -7.953%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

🟩 throughput [+34913.627op/s; +41276.569op/s] or [+5.167%; +6.109%]

dd-trace-dotnet-ci-bot · 2026-03-24T20:15:11Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8363) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	68.51 ± (68.62 - 68.92) ms	68.51 ± (68.52 - 68.78) ms	-0.0%	✅
.NET Framework 4.8 - Bailout
duration	72.49 ± (72.44 - 72.72) ms	72.60 ± (72.52 - 72.75) ms	+0.2%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1037.57 ± (1041.39 - 1050.46) ms	1045.07 ± (1047.28 - 1054.54) ms	+0.7%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	21.79 ± (21.77 - 21.82) ms	21.82 ± (21.78 - 21.85) ms	+0.1%	✅⬆️
process.time_to_main_ms	79.39 ± (79.23 - 79.55) ms	79.24 ± (79.09 - 79.39) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.90 ± (10.89 - 10.90) MB	10.90 ± (10.90 - 10.91) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	21.77 ± (21.74 - 21.80) ms	21.75 ± (21.73 - 21.78) ms	-0.1%	✅
process.time_to_main_ms	80.75 ± (80.57 - 80.93) ms	80.59 ± (80.42 - 80.75) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.94 ± (10.93 - 10.94) MB	10.93 ± (10.93 - 10.94) MB	-0.1%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	217.96 ± (216.60 - 219.32) ms	217.06 ± (216.03 - 218.09) ms	-0.4%	✅
process.time_to_main_ms	514.40 ± (513.26 - 515.55) ms	518.56 ± (517.57 - 519.54) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.20 ± (48.17 - 48.24) MB	48.29 ± (48.27 - 48.32) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.6%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	20.56 ± (20.54 - 20.59) ms	20.54 ± (20.51 - 20.56) ms	-0.1%	✅
process.time_to_main_ms	68.77 ± (68.63 - 68.90) ms	68.72 ± (68.60 - 68.84) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.62 ± (10.62 - 10.62) MB	10.62 ± (10.61 - 10.62) MB	-0.0%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.42 ± (20.40 - 20.44) ms	20.38 ± (20.36 - 20.40) ms	-0.2%	✅
process.time_to_main_ms	69.59 ± (69.48 - 69.70) ms	69.46 ± (69.37 - 69.55) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.73 ± (10.73 - 10.74) MB	10.73 ± (10.73 - 10.74) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	205.12 ± (204.11 - 206.13) ms	207.47 ± (206.31 - 208.63) ms	+1.1%	✅⬆️
process.time_to_main_ms	516.08 ± (515.09 - 517.07) ms	519.51 ± (518.41 - 520.60) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.99 ± (49.95 - 50.03) MB	50.08 ± (50.04 - 50.12) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	-0.1%	✅
.NET 8 - Baseline
process.internal_duration_ms	18.83 ± (18.80 - 18.85) ms	18.85 ± (18.82 - 18.87) ms	+0.1%	✅⬆️
process.time_to_main_ms	68.02 ± (67.89 - 68.14) ms	68.32 ± (68.19 - 68.44) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.69 ± (7.69 - 7.70) MB	7.68 ± (7.68 - 7.68) MB	-0.2%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	18.84 ± (18.81 - 18.87) ms	18.88 ± (18.85 - 18.91) ms	+0.2%	✅⬆️
process.time_to_main_ms	69.14 ± (69.05 - 69.23) ms	69.30 ± (69.18 - 69.41) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.77 ± (7.76 - 7.78) MB	7.75 ± (7.74 - 7.77) MB	-0.2%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	154.63 ± (153.85 - 155.42) ms	153.53 ± (152.86 - 154.19) ms	-0.7%	✅
process.time_to_main_ms	474.72 ± (473.83 - 475.60) ms	477.64 ± (476.86 - 478.42) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	36.90 ± (36.88 - 36.92) MB	36.92 ± (36.90 - 36.94) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.0%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	218.25 ± (217.77 - 219.30) ms	224.64 ± (224.38 - 226.51) ms	+2.9%	✅⬆️
.NET Framework 4.8 - Bailout
duration	224.17 ± (224.83 - 226.79) ms	227.17 ± (226.57 - 228.63) ms	+1.3%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1248.94 ± (1247.47 - 1254.17) ms	1269.30 ± (1263.83 - 1271.93) ms	+1.6%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	213.24 ± (212.59 - 213.90) ms	218.65 ± (217.54 - 219.76) ms	+2.5%	✅⬆️
process.time_to_main_ms	91.82 ± (91.54 - 92.09) ms	92.90 ± (92.45 - 93.35) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.87 ± (15.86 - 15.89) MB	15.80 ± (15.79 - 15.82) MB	-0.4%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	+0.6%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	213.94 ± (213.27 - 214.62) ms	214.58 ± (213.66 - 215.50) ms	+0.3%	✅⬆️
process.time_to_main_ms	93.54 ± (93.30 - 93.79) ms	93.27 ± (93.01 - 93.52) ms	-0.3%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.90 ± (15.88 - 15.91) MB	15.90 ± (15.89 - 15.92) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	+0.1%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	422.32 ± (420.93 - 423.71) ms	424.27 ± (423.04 - 425.50) ms	+0.5%	✅⬆️
process.time_to_main_ms	565.90 ± (564.44 - 567.35) ms	570.39 ± (569.09 - 571.69) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	59.03 ± (58.98 - 59.07) MB	59.09 ± (59.05 - 59.13) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	220.56 ± (219.70 - 221.43) ms	227.69 ± (226.56 - 228.82) ms	+3.2%	✅⬆️
process.time_to_main_ms	79.74 ± (79.53 - 79.95) ms	80.64 ± (80.33 - 80.95) ms	+1.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.12 ± (16.10 - 16.13) MB	16.11 ± (16.09 - 16.13) MB	-0.0%	✅
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (19 - 20)	+0.2%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	220.61 ± (219.77 - 221.45) ms	224.15 ± (223.02 - 225.28) ms	+1.6%	✅⬆️
process.time_to_main_ms	80.94 ± (80.70 - 81.18) ms	81.21 ± (80.94 - 81.48) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.17 ± (16.16 - 16.19) MB	16.15 ± (16.13 - 16.16) MB	-0.2%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (20 - 21)	-0.2%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	451.14 ± (448.64 - 453.64) ms	464.01 ± (458.55 - 469.48) ms	+2.9%	✅⬆️
process.time_to_main_ms	571.14 ± (569.83 - 572.45) ms	575.43 ± (574.15 - 576.70) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	60.65 ± (60.58 - 60.73) MB	60.62 ± (60.54 - 60.70) MB	-0.1%	✅
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	+0.2%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	217.50 ± (216.66 - 218.34) ms	219.98 ± (218.98 - 220.98) ms	+1.1%	✅⬆️
process.time_to_main_ms	78.23 ± (78.00 - 78.45) ms	78.56 ± (78.35 - 78.78) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.44 ± (11.42 - 11.45) MB	11.50 ± (11.48 - 11.51) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.1%	✅
.NET 8 - Bailout
process.internal_duration_ms	217.68 ± (216.81 - 218.55) ms	220.02 ± (218.71 - 221.33) ms	+1.1%	✅⬆️
process.time_to_main_ms	80.04 ± (79.78 - 80.31) ms	80.27 ± (80.02 - 80.52) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.46 ± (11.45 - 11.48) MB	11.52 ± (11.50 - 11.53) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.3%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	452.19 ± (446.13 - 458.26) ms	450.65 ± (442.66 - 458.65) ms	-0.3%	✅
process.time_to_main_ms	528.33 ± (527.25 - 529.42) ms	528.00 ± (526.74 - 529.26) ms	-0.1%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.46 ± (50.35 - 50.58) MB	50.41 ± (50.26 - 50.57) MB	-0.1%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (69ms)  : 67, 71
    master - mean (69ms)  : 67, 71

    section Bailout
    This PR (8363) - mean (73ms)  : 72, 74
    master - mean (73ms)  : 71, 74

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (1,051ms)  : 998, 1103
    master - mean (1,046ms)  : 981, 1111

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (107ms)  : 104, 110
    master - mean (107ms)  : 103, 110

    section Bailout
    This PR (8363) - mean (108ms)  : 106, 110
    master - mean (108ms)  : 106, 110

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (771ms)  : 744, 798
    master - mean (769ms)  : 750, 789

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (94ms)  : 92, 96
    master - mean (95ms)  : 92, 97

    section Bailout
    This PR (8363) - mean (95ms)  : 94, 96
    master - mean (95ms)  : 94, 96

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (763ms)  : 743, 783
    master - mean (755ms)  : 734, 776

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (94ms)  : 91, 97
    master - mean (93ms)  : 91, 95

    section Bailout
    This PR (8363) - mean (95ms)  : 93, 97
    master - mean (95ms)  : 93, 96

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (665ms)  : 639, 690
    master - mean (663ms)  : 639, 687

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (225ms)  : 210, 241
    master - mean (219ms)  : 207, 230

    section Bailout
    This PR (8363) - mean (228ms)  : 213, 243
    master - mean (226ms)  : 211, 241

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (1,268ms)  : 1210, 1325
    master - mean (1,251ms)  : 1203, 1299

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (322ms)  : 300, 344
    master - mean (315ms)  : 300, 331

    section Bailout
    This PR (8363) - mean (318ms)  : 301, 336
    master - mean (317ms)  : 304, 330

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (1,036ms)  : 1001, 1070
    master - mean (1,030ms)  : 998, 1061

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (318ms)  : 299, 337
    master - mean (310ms)  : 292, 328

    section Bailout
    This PR (8363) - mean (314ms)  : 296, 333
    master - mean (311ms)  : 293, 329

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (1,079ms)  : 992, 1165
    master - mean (1,061ms)  : 1007, 1115

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8363) - mean (310ms)  : 293, 327
    master - mean (307ms)  : 290, 323

    section Bailout
    This PR (8363) - mean (311ms)  : 288, 334
    master - mean (310ms)  : 289, 331

    section CallTarget+Inlining+NGEN
    This PR (8363) - mean (1,016ms)  : 922, 1111
    master - mean (1,025ms)  : 944, 1105

lucaspimentel · 2026-03-24T20:50:20Z

Related: #8061 seems to remove that log message. Should we keep it?

The ContainerTagsHash property moved from ContainerMetadata to ServiceRemappingHash.

lucaspimentel · 2026-03-24T20:56:23Z

tracer/src/Datadog.Trace/Agent/DiscoveryService/DiscoveryService.cs


        private async Task ProcessDiscoveryResponse(IApiResponse response)
        {
+#if !NETFRAMEWORK


I think we can skip this in Windows regardless of .NET version, since we won't have container tags?

But these container tags come from the Agent. What happens if the tracer is running on Windows and the Agent is running in a Linux container, or (less probably) vice-versa?

I removed the setter code entirely from .NET Framework

Is that what you meant to do? I didn't notice that this was being changed in that other PR as well

Instead of guarding the caller with #if !NETFRAMEWORK, make the setter a silent no-op. This avoids conflict with #8061 which replaces the caller entirely.

bouwkast requested a review from a team as a code owner March 24, 2026 19:11

bouwkast added the identified-by:telemetry label Mar 24, 2026

github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) and removed identified-by:telemetry labels Mar 24, 2026

lucaspimentel mentioned this pull request Mar 24, 2026

[DBM] Add container tags hash to queries (if enabled) #8061

Open

lucaspimentel reviewed Mar 24, 2026

View reviewed changes

Remove ContainerTagsHash Log.Error on .NET Framework

2893a40

Instead of guarding the caller with #if !NETFRAMEWORK, make the setter a silent no-op. This avoids conflict with #8061 which replaces the caller entirely.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrap ContainerTagsHash around !NETFRAMEWORK#8363

Wrap ContainerTagsHash around !NETFRAMEWORK#8363
bouwkast wants to merge 2 commits intomasterfrom
steven/the-code-fix

bouwkast commented Mar 24, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Mar 24, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 24, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

lucaspimentel commented Mar 24, 2026 •

edited

Loading

Uh oh!

lucaspimentel Mar 24, 2026

Uh oh!

bouwkast Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bouwkast commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

pr-commenter bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 24, 2026

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

lucaspimentel commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucaspimentel Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

bouwkast Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bouwkast commented Mar 24, 2026 •

edited

Loading

pr-commenter bot commented Mar 24, 2026 •

edited

Loading

lucaspimentel commented Mar 24, 2026 •

edited

Loading