Skip to content

Wrap ContainerTagsHash around !NETFRAMEWORK #8363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bouwkast wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −14
Open

Wrap ContainerTagsHash around !NETFRAMEWORK #8363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64b2ad9
Wrap ContainerTagsHash around !NETFRAMEWORK
bouwkast Mar 24, 2026
2893a40
Remove ContainerTagsHash Log.Error on .NET Framework
bouwkast Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions tracer/src/Datadog.Trace/PlatformHelpers/ContainerMetadata.NetFramework.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@

#nullable enable

using System.Threading;
using Datadog.Trace.Logging;

#if NETFRAMEWORK

namespace Datadog.Trace.PlatformHelpers;
Expand All @@ -17,9 +14,6 @@ namespace Datadog.Trace.PlatformHelpers;
/// </summary>
internal sealed class ContainerMetadata
{
private static readonly IDatadogLogger Log = DatadogLogging.GetLoggerFor(typeof(ContainerMetadata));
private static bool _warnedOnSet; // to log only once

public static readonly ContainerMetadata Instance = new();

private ContainerMetadata()
Expand All @@ -36,14 +30,7 @@ public ContainerMetadata(string containerId, string entityId)
public string? ContainerTagsHash
{
get => null;
set
{
if (!_warnedOnSet)
{
_warnedOnSet = true;
Log.Error("The code is trying to set the value '{Value}' to {Prop}, but this has no effect in .NET Framework.", value, nameof(ContainerTagsHash));
}
}
set { }
}

/// <summary>
Expand Down
Loading