Revert YARP exclusion by andrewlock · Pull Request #8407 · DataDog/dd-trace-dotnet

andrewlock · 2026-04-02T12:52:40Z

Summary of changes

Reverts including YARP spans in the ignore handler

Reason for change

We were a bit hasty including this in #8370

Implementation details

Remove it again

Test coverage

Explicitly disabling OTel in the test instead for now. There's nothing wrong with the span, just inconsistency between versions. We could consider having different snapshots, but I'll do that as part of a follow up, as its important to get this in fast

dd-trace-dotnet-ci-bot · 2026-04-02T13:55:47Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8407) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	72.27 ± (72.40 - 72.79) ms	76.32 ± (76.20 - 76.55) ms	+5.6%	✅⬆️
.NET Framework 4.8 - Bailout
duration	76.16 ± (76.05 - 76.40) ms	80.13 ± (79.92 - 80.28) ms	+5.2%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1095.57 ± (1093.81 - 1101.85) ms	1109.89 ± (1109.20 - 1114.81) ms	+1.3%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	23.13 ± (23.07 - 23.19) ms	23.17 ± (23.12 - 23.22) ms	+0.2%	✅⬆️
process.time_to_main_ms	88.89 ± (88.69 - 89.09) ms	88.96 ± (88.75 - 89.18) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.91 ± (10.91 - 10.92) MB	10.92 ± (10.92 - 10.93) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	23.14 ± (23.09 - 23.19) ms	23.17 ± (23.12 - 23.23) ms	+0.2%	✅⬆️
process.time_to_main_ms	90.36 ± (90.14 - 90.59) ms	90.88 ± (90.64 - 91.11) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.95 ± (10.95 - 10.96) MB	10.96 ± (10.95 - 10.96) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	235.16 ± (234.14 - 236.17) ms	232.90 ± (231.59 - 234.21) ms	-1.0%	✅
process.time_to_main_ms	544.41 ± (543.08 - 545.73) ms	544.05 ± (542.68 - 545.42) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.82 ± (47.79 - 47.84) MB	47.88 ± (47.84 - 47.91) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 29)	28 ± (28 - 28)	-0.1%	✅
.NET 6 - Baseline
process.internal_duration_ms	22.05 ± (22.00 - 22.10) ms	21.99 ± (21.95 - 22.04) ms	-0.3%	✅
process.time_to_main_ms	77.56 ± (77.35 - 77.76) ms	77.47 ± (77.29 - 77.65) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.63 ± (10.63 - 10.63) MB	10.63 ± (10.62 - 10.63) MB	-0.0%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.90 ± (21.84 - 21.95) ms	21.83 ± (21.77 - 21.88) ms	-0.3%	✅
process.time_to_main_ms	78.38 ± (78.20 - 78.55) ms	78.35 ± (78.16 - 78.55) ms	-0.0%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.70 ± (10.69 - 10.71) MB	10.74 ± (10.74 - 10.74) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	385.09 ± (382.71 - 387.47) ms	385.17 ± (382.66 - 387.67) ms	+0.0%	✅⬆️
process.time_to_main_ms	540.26 ± (539.26 - 541.27) ms	541.60 ± (540.26 - 542.95) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.84 ± (49.81 - 49.87) MB	49.90 ± (49.87 - 49.93) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	20.03 ± (19.98 - 20.08) ms	20.23 ± (20.18 - 20.28) ms	+1.0%	✅⬆️
process.time_to_main_ms	75.92 ± (75.75 - 76.08) ms	76.69 ± (76.53 - 76.85) ms	+1.0%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.66 ± (7.66 - 7.66) MB	7.69 ± (7.69 - 7.70) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.96 ± (19.91 - 20.01) ms	20.13 ± (20.08 - 20.17) ms	+0.8%	✅⬆️
process.time_to_main_ms	76.96 ± (76.75 - 77.17) ms	77.44 ± (77.24 - 77.63) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.73 ± (7.72 - 7.74) MB	7.76 ± (7.75 - 7.77) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	304.59 ± (302.32 - 306.85) ms	309.57 ± (306.78 - 312.37) ms	+1.6%	✅⬆️
process.time_to_main_ms	499.98 ± (499.16 - 500.79) ms	502.69 ± (501.83 - 503.56) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.10 ± (37.07 - 37.13) MB	37.09 ± (37.05 - 37.12) MB	-0.0%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.2%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	213.57 ± (213.09 - 214.03) ms	216.34 ± (216.36 - 217.35) ms	+1.3%	✅⬆️
.NET Framework 4.8 - Bailout
duration	217.56 ± (217.20 - 218.23) ms	221.12 ± (220.96 - 222.23) ms	+1.6%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1219.98 ± (1221.50 - 1229.71) ms	1253.82 ± (1251.53 - 1259.04) ms	+2.8%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	203.57 ± (203.06 - 204.08) ms	211.32 ± (210.69 - 211.95) ms	+3.8%	✅⬆️
process.time_to_main_ms	88.68 ± (88.44 - 88.91) ms	92.37 ± (92.07 - 92.67) ms	+4.2%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.96 ± (15.94 - 15.97) MB	15.86 ± (15.84 - 15.88) MB	-0.6%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	+0.1%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	203.96 ± (203.44 - 204.47) ms	209.46 ± (209.03 - 209.89) ms	+2.7%	✅⬆️
process.time_to_main_ms	89.58 ± (89.38 - 89.78) ms	92.89 ± (92.63 - 93.14) ms	+3.7%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.99 ± (15.96 - 16.01) MB	15.95 ± (15.93 - 15.97) MB	-0.2%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	+1.5%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	414.12 ± (412.70 - 415.54) ms	424.24 ± (422.88 - 425.60) ms	+2.4%	✅⬆️
process.time_to_main_ms	544.31 ± (542.89 - 545.73) ms	558.20 ± (556.69 - 559.71) ms	+2.6%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	58.67 ± (58.63 - 58.72) MB	58.81 ± (58.77 - 58.84) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.6%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	207.51 ± (206.97 - 208.05) ms	216.77 ± (216.26 - 217.27) ms	+4.5%	✅⬆️
process.time_to_main_ms	76.54 ± (76.30 - 76.78) ms	80.56 ± (80.31 - 80.81) ms	+5.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.23 ± (16.21 - 16.26) MB	16.15 ± (16.13 - 16.17) MB	-0.5%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	20 ± (19 - 20)	+0.9%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	205.34 ± (204.82 - 205.85) ms	216.49 ± (215.99 - 216.99) ms	+5.4%	✅⬆️
process.time_to_main_ms	77.17 ± (76.95 - 77.38) ms	81.86 ± (81.56 - 82.15) ms	+6.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.28 ± (16.26 - 16.31) MB	16.20 ± (16.18 - 16.22) MB	-0.5%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	21 ± (20 - 21)	+2.0%	✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	599.33 ± (596.69 - 601.97) ms	601.01 ± (598.16 - 603.87) ms	+0.3%	✅⬆️
process.time_to_main_ms	548.76 ± (547.58 - 549.94) ms	566.33 ± (564.67 - 568.00) ms	+3.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.38 ± (61.28 - 61.47) MB	61.32 ± (61.20 - 61.43) MB	-0.1%	✅
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	+0.1%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	209.35 ± (208.84 - 209.86) ms	213.81 ± (213.25 - 214.38) ms	+2.1%	✅⬆️
process.time_to_main_ms	77.68 ± (77.42 - 77.95) ms	79.28 ± (79.07 - 79.49) ms	+2.0%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.61 ± (11.60 - 11.63) MB	11.55 ± (11.54 - 11.57) MB	-0.5%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+0.7%	✅⬆️
.NET 8 - Bailout
process.internal_duration_ms	207.94 ± (207.39 - 208.49) ms	214.38 ± (213.89 - 214.87) ms	+3.1%	✅⬆️
process.time_to_main_ms	78.42 ± (78.13 - 78.71) ms	80.87 ± (80.59 - 81.15) ms	+3.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.69 ± (11.67 - 11.71) MB	11.63 ± (11.61 - 11.66) MB	-0.4%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	+1.5%	✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	536.46 ± (530.34 - 542.57) ms	582.56 ± (574.63 - 590.50) ms	+8.6%	✅⬆️
process.time_to_main_ms	508.23 ± (507.17 - 509.29) ms	520.04 ± (518.84 - 521.24) ms	+2.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.77 ± (50.69 - 50.85) MB	51.32 ± (51.22 - 51.41) MB	+1.1%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.3%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (76ms)  : 74, 79
    master - mean (73ms)  : 70, 76

    section Bailout
    This PR (8407) - mean (80ms)  : 78, 82
    master - mean (76ms)  : 75, 78

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (1,112ms)  : 1072, 1152
    master - mean (1,098ms)  : 1039, 1157

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (120ms)  : 115, 124
    master - mean (119ms)  : 116, 123

    section Bailout
    This PR (8407) - mean (121ms)  : 117, 125
    master - mean (121ms)  : 117, 125

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (818ms)  : 800, 835
    master - mean (818ms)  : 795, 841

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (106ms)  : 103, 110
    master - mean (106ms)  : 103, 110

    section Bailout
    This PR (8407) - mean (107ms)  : 103, 111
    master - mean (107ms)  : 105, 109

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (955ms)  : 921, 990
    master - mean (956ms)  : 918, 993

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (105ms)  : 102, 108
    master - mean (104ms)  : 101, 107

    section Bailout
    This PR (8407) - mean (105ms)  : 103, 108
    master - mean (105ms)  : 103, 107

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (843ms)  : 800, 887
    master - mean (836ms)  : 801, 870

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (217ms)  : 211, 223
    master - mean (214ms)  : 207, 220

    section Bailout
    This PR (8407) - mean (222ms)  : 215, 229
    master - mean (218ms)  : 212, 223

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (1,255ms)  : 1199, 1311
    master - mean (1,226ms)  : 1164, 1287

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (313ms)  : 305, 321
    master - mean (302ms)  : 293, 311

    section Bailout
    This PR (8407) - mean (312ms)  : 307, 318
    master - mean (303ms)  : 297, 309

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (1,023ms)  : 992, 1055
    master - mean (999ms)  : 974, 1024

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (307ms)  : 300, 314
    master - mean (293ms)  : 285, 301

    section Bailout
    This PR (8407) - mean (308ms)  : crit, 299, 316
    master - mean (291ms)  : 284, 299

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (1,199ms)  : 1163, 1235
    master - mean (1,179ms)  : 1140, 1219

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8407) - mean (304ms)  : 295, 312
    master - mean (298ms)  : 290, 306

    section Bailout
    This PR (8407) - mean (306ms)  : 299, 313
    master - mean (297ms)  : 291, 304

    section CallTarget+Inlining+NGEN
    This PR (8407) - mean (1,134ms)  : 1014, 1253
    master - mean (1,080ms)  : 994, 1166

Revert YARP exclusion

fdee721

andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) labels Apr 2, 2026

Disable OTEL for the Yarp tests for now

764f1a2

andrewlock marked this pull request as ready for review April 2, 2026 14:29

andrewlock requested review from a team as code owners April 2, 2026 14:29

andrewlock requested a review from zacharycmontoya April 2, 2026 14:29

zacharycmontoya approved these changes Apr 2, 2026

View reviewed changes

bouwkast approved these changes Apr 2, 2026

View reviewed changes

andrewlock enabled auto-merge (squash) April 2, 2026 14:45

andrewlock merged commit ef71061 into master Apr 2, 2026
138 of 139 checks passed

andrewlock deleted the andrew/revert-yarp-exclusion branch April 2, 2026 18:13

github-actions bot added this to the vNext-v3 milestone Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert YARP exclusion#8407

Revert YARP exclusion#8407
andrewlock merged 2 commits intomasterfrom
andrew/revert-yarp-exclusion

andrewlock commented Apr 2, 2026 •

edited

Loading

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026 •

edited

Loading

FakeDbCommand

HttpMessageHandler

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andrewlock commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewlock commented Apr 2, 2026 •

edited

Loading

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026 •

edited

Loading