Skip to content

Revert YARP exclusion #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewlock merged 2 commits into from
Apr 2, 2026
+2 −1
Merged

Revert YARP exclusion #8407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdee721
Revert YARP exclusion
andrewlock Apr 2, 2026
764f1a2
Disable OTEL for the Yarp tests for now
andrewlock Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tracer/src/Datadog.Trace/Activity/Handlers/IgnoreActivityHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ internal sealed class IgnoreActivityHandler : IActivityHandler
"Experimental.System.Net.Http.Connections",
"Experimental.System.Net.Security",
"Experimental.System.Net.Sockets",
"Yarp.ReverseProxy",
};

public static bool ShouldIgnoreByOperationName(string? operationName)
Expand Down
2 changes: 2 additions & 0 deletions tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/YarpDistributedTracingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public YarpDistributedTracingTests(ITestOutputHelper output)
: base("Yarp.DistributedTracing", output)
{
SetServiceVersion(ServiceVersion);
// This generates an extra span in some versions of YARP, so for simplicity, we exclude it
SetEnvironmentVariable("DD_TRACE_OTEL_ENABLED", "false");
}

public override Result ValidateIntegrationSpan(MockSpan span, string metadataSchemaVersion) => Result.DefaultSuccess;
Expand Down
Loading