[Debugger] Improve line probe source path resolution by dudikeleti · Pull Request #8422 · DataDog/dd-trace-dotnet

dudikeleti · 2026-04-07T21:10:31Z

Summary of changes

Improve line probe source path resolution when probe paths and PDB document paths differ only by source root.
Split the previous unbound reason into clearer cases for loaded-assembly source-path mismatches vs. assembly-not-loaded-or-symbols-unavailable.
Add a conservative trailing-segment fallback that binds probes only when the file match is unique.
Preserve exact PDB paths across Windows, Linux, and UNC-style paths while tolerating trailing separators in probe queries.
Expand debug logging with path match diagnostics, including fallback failure reasons and matching segment counts.
Reduce resolver overhead by avoiding duplicate assembly scans, caching exact-match query data, and returning minimal diagnostics outside debug logging.
Extend test coverage for fallback matching, ambiguity, case sensitivity, UNC paths, trailing separators, and minimal-diagnostics behavior.

Reason for change

Recent customer investigation showed that some unbound probes were caused by source-path mismatches, while the existing diagnostics could look like an assembly load issue.
Different build/source roots can leave otherwise valid probes unbound even when the assembly and symbols are present.
The resolver runs on a sensitive path, so the improved diagnostics should not add unnecessary allocation cost when debug logging is disabled.

Implementation details

Keep exact suffix matching as the first resolution strategy, then apply fallback only when at least four trailing path segments match and the best match is unique.
Reject case-only differences, file-name-only matches, and ambiguous fallback candidates to avoid binding probes to the wrong file.
Add explicit diagnostic fields for path match type, trailing-segment counts, and fallback failure reasons in full diagnostic mode.
Let DynamicInstrumentation request only minimal diagnostics when debug logging is off, while preserving full diagnostics for debug and direct resolver callers.
Use span-based path handling and cached exact-match query data to reduce repeated string allocations.

Test coverage

dotnet test "tracer/test/Datadog.Trace.Debugger.IntegrationTests/Datadog.Trace.Debugger.IntegrationTests.csproj" --filter "FullyQualifiedName~LineProbeResolverTest"
dotnet test "tracer/test/Datadog.Trace.Tests/Datadog.Trace.Tests.csproj" --filter "FullyQualifiedName~DynamicInstrumentationTests"

Other details

The fallback behavior is intentionally conservative: if multiple files match equally well, the probe remains unbound.
The updated debug diagnostics should make future customer investigations much less misleading.

…iagnostics implied the assembly was missing. Clarify source-path mismatch reporting, add conservative suffix fallback matching, and avoid building full resolver diagnostics outside debug so these cases are easier to diagnose without adding unnecessary allocation cost.

Copilot

Pull request overview

This PR significantly improves line probe source path resolution by implementing a conservative fallback matching strategy, splitting ambiguous diagnostics reasons into clearer cases, and introducing diagnostic level controls to reduce allocation overhead. The changes allow probes to be resolved even when source paths differ by leading path segments, while maintaining correctness through strict matching criteria and comprehensive diagnostics.

Changes:

Split AssemblyNotLoadedOrSourceFileMismatch reason into LoadedAssemblySourceFileMismatch and AssemblyNotLoadedOrSymbolsUnavailable for clearer diagnostics
Added conservative trailing-segment fallback matching that binds probes only when the file match is unique and meets minimum segment threshold (4 segments)
Introduced LineProbeDiagnosticLevel enum to control diagnostic detail (Minimal vs Full), reducing allocation when debug logging is disabled
Enhanced diagnostics with PathMatchType, MatchingTrailingSegments, FallbackFailureReason, and QualifiedFallbackMatchCount fields
Implemented span-based path handling and caching of reversed paths in ProbePathQuery struct for performance
Added comprehensive test coverage for fallback matching scenarios, ambiguity handling, case sensitivity, UNC paths, and trailing separator handling

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tracer/src/Datadog.Trace/Debugger/Models/LiveProbeResolveStatus.cs	Added new enums for reasons, path match types, fallback failure reasons, and diagnostic levels
tracer/src/Datadog.Trace/Debugger/Models/LineProbeResolutionDiagnostics.cs	Added new diagnostic fields for path matching details and updated summary formatting
tracer/src/Datadog.Trace/Debugger/ILineProbeResolver.cs	Updated interface to include diagnostic level parameter with full default
tracer/src/Datadog.Trace/Debugger/LineProbeResolver.cs	Major refactor implementing fallback matching, span-based path handling, and diagnostic level support
tracer/src/Datadog.Trace/Debugger/DynamicInstrumentation.cs	Updated to determine diagnostic level from log level and pass to resolver; enhanced logging with new diagnostic fields
tracer/test/Datadog.Trace.Tests/Debugger/DynamicInstrumentationTests.cs	Updated mock interface implementation to match new signature with diagnostic level parameter
tracer/test/Datadog.Trace.Debugger.IntegrationTests/LineProbeResolverTest.cs	Added comprehensive tests for fallback matching, trailing separators, case sensitivity, ambiguity, and diagnostic levels

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pr-commenter · 2026-04-07T21:55:47Z

Benchmarks

Benchmark execution time: 2026-04-07 21:55:44

Comparing candidate commit b21dde9 in PR branch fix/line-probe-path-fallback with baseline commit 275c3a4 in branch master.

Found 6 performance improvements and 7 performance regressions! Performance is the same for 256 metrics, 19 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟩 execution_time [-86.989ms; -86.568ms] or [-43.452%; -43.241%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

🟥 execution_time [+21.644ms; +22.105ms] or [+11.980%; +12.235%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

🟥 execution_time [+13.522ms; +19.871ms] or [+6.733%; +9.894%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟥 throughput [-271.326op/s; -242.585op/s] or [-16.526%; -14.775%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟥 execution_time [+73.452ms; +79.312ms] or [+47.859%; +51.676%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

🟩 execution_time [-165.448µs; -157.565µs] or [-10.862%; -10.344%]
🟩 throughput [+76.016op/s; +79.707op/s] or [+11.579%; +12.141%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

🟩 execution_time [-1.907ms; -1.901ms] or [-47.228%; -47.085%]
🟩 throughput [+220.441op/s; +221.564op/s] or [+89.013%; +89.466%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

🟥 allocated_mem [+17.650KB; +17.688KB] or [+6.878%; +6.892%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

🟥 allocated_mem [+19.777KB; +19.804KB] or [+7.743%; +7.754%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472

🟥 throughput [-34479.300op/s; -31987.933op/s] or [-7.557%; -7.011%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

🟩 throughput [+56849.537op/s; +61599.860op/s] or [+6.535%; +7.081%]

dd-trace-dotnet-ci-bot · 2026-04-07T21:59:30Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8422) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	75.89 ± (75.82 - 76.16) ms	75.52 ± (75.33 - 75.73) ms	-0.5%	✅
.NET Framework 4.8 - Bailout
duration	81.23 ± (81.03 - 81.42) ms	80.03 ± (79.94 - 80.32) ms	-1.5%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1108.04 ± (1109.03 - 1114.66) ms	1096.85 ± (1096.61 - 1101.89) ms	-1.0%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	23.39 ± (23.33 - 23.45) ms	22.95 ± (22.91 - 23.00) ms	-1.9%	✅
process.time_to_main_ms	89.84 ± (89.62 - 90.06) ms	87.63 ± (87.43 - 87.82) ms	-2.5%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.92 ± (10.91 - 10.92) MB	10.93 ± (10.93 - 10.94) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	23.25 ± (23.19 - 23.31) ms	22.90 ± (22.85 - 22.95) ms	-1.5%	✅
process.time_to_main_ms	90.51 ± (90.27 - 90.75) ms	89.05 ± (88.82 - 89.27) ms	-1.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.95 ± (10.94 - 10.95) MB	10.96 ± (10.96 - 10.97) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	233.55 ± (232.37 - 234.72) ms	231.19 ± (229.84 - 232.53) ms	-1.0%	✅
process.time_to_main_ms	543.66 ± (542.52 - 544.79) ms	536.67 ± (535.30 - 538.03) ms	-1.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.82 ± (47.79 - 47.85) MB	48.29 ± (48.26 - 48.32) MB	+1.0%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 29)	28 ± (28 - 28)	-1.1%	✅
.NET 6 - Baseline
process.internal_duration_ms	22.00 ± (21.95 - 22.05) ms	21.51 ± (21.46 - 21.57) ms	-2.2%	✅
process.time_to_main_ms	77.58 ± (77.39 - 77.77) ms	75.33 ± (75.15 - 75.51) ms	-2.9%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.63 ± (10.62 - 10.63) MB	10.64 ± (10.63 - 10.64) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.89 ± (21.84 - 21.95) ms	21.54 ± (21.49 - 21.59) ms	-1.6%	✅
process.time_to_main_ms	79.02 ± (78.82 - 79.22) ms	76.82 ± (76.61 - 77.02) ms	-2.8%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.74 ± (10.74 - 10.74) MB	10.75 ± (10.75 - 10.76) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	385.29 ± (383.04 - 387.55) ms	384.55 ± (382.67 - 386.43) ms	-0.2%	✅
process.time_to_main_ms	544.30 ± (542.82 - 545.78) ms	531.13 ± (530.21 - 532.05) ms	-2.4%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.82 ± (49.79 - 49.85) MB	50.06 ± (50.03 - 50.09) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	20.25 ± (20.21 - 20.29) ms	19.71 ± (19.67 - 19.75) ms	-2.7%	✅
process.time_to_main_ms	76.95 ± (76.79 - 77.12) ms	74.72 ± (74.53 - 74.90) ms	-2.9%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.68 ± (7.67 - 7.68) MB	7.68 ± (7.68 - 7.69) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	20.25 ± (20.20 - 20.29) ms	19.82 ± (19.78 - 19.85) ms	-2.1%	✅
process.time_to_main_ms	78.49 ± (78.30 - 78.68) ms	76.01 ± (75.83 - 76.19) ms	-3.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.74 ± (7.73 - 7.75) MB	7.74 ± (7.73 - 7.74) MB	-0.0%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	305.49 ± (303.32 - 307.65) ms	308.38 ± (306.19 - 310.57) ms	+0.9%	✅⬆️
process.time_to_main_ms	507.97 ± (507.00 - 508.94) ms	494.36 ± (493.48 - 495.25) ms	-2.7%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.13 ± (37.10 - 37.15) MB	37.08 ± (37.04 - 37.11) MB	-0.1%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	+0.0%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	215.04 ± (214.99 - 215.91) ms	209.14 ± (208.80 - 209.69) ms	-2.7%	✅
.NET Framework 4.8 - Bailout
duration	220.32 ± (220.02 - 220.95) ms	214.65 ± (214.30 - 215.28) ms	-2.6%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1241.14 ± (1241.46 - 1248.21) ms	1210.95 ± (1213.12 - 1221.10) ms	-2.4%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	209.32 ± (208.87 - 209.78) ms	202.92 ± (202.37 - 203.47) ms	-3.1%	✅
process.time_to_main_ms	91.84 ± (91.54 - 92.13) ms	88.36 ± (88.02 - 88.70) ms	-3.8%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.97 ± (15.95 - 15.99) MB	15.93 ± (15.91 - 15.95) MB	-0.3%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.8%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	208.73 ± (208.24 - 209.22) ms	203.08 ± (202.56 - 203.60) ms	-2.7%	✅
process.time_to_main_ms	92.71 ± (92.46 - 92.96) ms	89.93 ± (89.66 - 90.20) ms	-3.0%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.94 ± (15.92 - 15.97) MB	15.97 ± (15.95 - 15.99) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	-0.2%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	422.42 ± (420.83 - 424.01) ms	416.39 ± (415.16 - 417.62) ms	-1.4%	✅
process.time_to_main_ms	554.94 ± (553.59 - 556.29) ms	543.70 ± (542.42 - 544.99) ms	-2.0%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	58.69 ± (58.64 - 58.73) MB	59.14 ± (59.09 - 59.19) MB	+0.8%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-1.0%	✅
.NET 6 - Baseline
process.internal_duration_ms	214.64 ± (214.12 - 215.16) ms	210.57 ± (210.06 - 211.08) ms	-1.9%	✅
process.time_to_main_ms	79.83 ± (79.58 - 80.08) ms	77.99 ± (77.74 - 78.24) ms	-2.3%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.14 ± (16.12 - 16.16) MB	16.22 ± (16.19 - 16.25) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	20 ± (19 - 20)	19 ± (19 - 20)	-0.3%	✅
.NET 6 - Bailout
process.internal_duration_ms	215.78 ± (215.27 - 216.29) ms	208.06 ± (207.63 - 208.49) ms	-3.6%	✅
process.time_to_main_ms	81.54 ± (81.32 - 81.77) ms	78.40 ± (78.14 - 78.65) ms	-3.9%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.17 ± (16.15 - 16.20) MB	16.26 ± (16.23 - 16.28) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	21 ± (20 - 21)	+0.7%	✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	601.08 ± (598.58 - 603.58) ms	605.30 ± (602.46 - 608.13) ms	+0.7%	✅⬆️
process.time_to_main_ms	559.94 ± (558.65 - 561.23) ms	546.05 ± (544.82 - 547.29) ms	-2.5%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.25 ± (61.14 - 61.37) MB	61.76 ± (61.66 - 61.85) MB	+0.8%	✅⬆️
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	-0.4%	✅
.NET 8 - Baseline
process.internal_duration_ms	212.79 ± (212.23 - 213.35) ms	205.60 ± (205.10 - 206.10) ms	-3.4%	✅
process.time_to_main_ms	78.94 ± (78.68 - 79.19) ms	75.79 ± (75.56 - 76.03) ms	-4.0%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.51 ± (11.49 - 11.53) MB	11.61 ± (11.59 - 11.63) MB	+0.9%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+0.1%	✅⬆️
.NET 8 - Bailout
process.internal_duration_ms	211.78 ± (211.28 - 212.27) ms	205.50 ± (204.98 - 206.03) ms	-3.0%	✅
process.time_to_main_ms	80.43 ± (80.16 - 80.70) ms	77.01 ± (76.80 - 77.22) ms	-4.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.57 ± (11.55 - 11.59) MB	11.67 ± (11.65 - 11.69) MB	+0.8%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-1.8%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	587.48 ± (579.86 - 595.10) ms	537.67 ± (531.43 - 543.90) ms	-8.5%	✅
process.time_to_main_ms	518.94 ± (517.73 - 520.16) ms	502.80 ± (501.95 - 503.65) ms	-3.1%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	51.43 ± (51.34 - 51.53) MB	50.77 ± (50.70 - 50.84) MB	-1.3%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.2%	✅

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (76ms)  : 73, 78
    master - mean (76ms)  : 74, 78

    section Bailout
    This PR (8422) - mean (80ms)  : 78, 82
    master - mean (81ms)  : 79, 84

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (1,099ms)  : 1061, 1137
    master - mean (1,112ms)  : 1071, 1153

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (118ms)  : 114, 122
    master - mean (121ms)  : 116, 125

    section Bailout
    This PR (8422) - mean (119ms)  : 116, 122
    master - mean (121ms)  : 118, 124

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (805ms)  : 784, 826
    master - mean (815ms)  : 791, 839

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (104ms)  : 101, 107
    master - mean (107ms)  : 103, 110

    section Bailout
    This PR (8422) - mean (105ms)  : 102, 108
    master - mean (108ms)  : 104, 112

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (945ms)  : 906, 985
    master - mean (960ms)  : 914, 1007

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (102ms)  : 99, 106
    master - mean (105ms)  : 101, 109

    section Bailout
    This PR (8422) - mean (104ms)  : 100, 108
    master - mean (107ms)  : 104, 110

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (834ms)  : 795, 873
    master - mean (844ms)  : 809, 880

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (209ms)  : 204, 215
    master - mean (215ms)  : 210, 221

    section Bailout
    This PR (8422) - mean (215ms)  : 208, 222
    master - mean (220ms)  : 216, 225

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (1,217ms)  : 1158, 1276
    master - mean (1,245ms)  : 1196, 1294

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (301ms)  : 292, 309
    master - mean (311ms)  : 304, 317

    section Bailout
    This PR (8422) - mean (302ms)  : 295, 309
    master - mean (311ms)  : 305, 318

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (993ms)  : 966, 1020
    master - mean (1,019ms)  : 987, 1052

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (297ms)  : 290, 304
    master - mean (303ms)  : 296, 311

    section Bailout
    This PR (8422) - mean (295ms)  : 290, 301
    master - mean (306ms)  : 299, 313

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (1,183ms)  : 1153, 1214
    master - mean (1,194ms)  : 1158, 1231

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8422) - mean (292ms)  : 285, 299
    master - mean (303ms)  : 295, 310

    section Bailout
    This PR (8422) - mean (293ms)  : 287, 299
    master - mean (302ms)  : 295, 310

    section CallTarget+Inlining+NGEN
    This PR (8422) - mean (1,074ms)  : 984, 1164
    master - mean (1,141ms)  : 1025, 1257

dudikeleti requested a review from Copilot April 7, 2026 21:11

github-actions bot added the area:debugger label Apr 7, 2026

Copilot started reviewing on behalf of dudikeleti April 7, 2026 21:12 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Debugger] Improve line probe source path resolution#8422

[Debugger] Improve line probe source path resolution#8422
dudikeleti wants to merge 1 commit intomasterfrom
fix/line-probe-path-fallback

dudikeleti commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

pr-commenter bot commented Apr 7, 2026

Explanation

More details about the CI and significant changes

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 7, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dudikeleti commented Apr 7, 2026

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

pr-commenter bot commented Apr 7, 2026

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 7, 2026

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants