chore(eslint): enable JSDoc parameter and type checks - #9566
Conversation
Overall package sizeSelf size: 7.8 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 441.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2c234e4 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-08-04 12:57:13 Comparing candidate commit 2c234e4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2315 metrics, 43 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9566 +/- ##
========================================
Coverage 98.51% 98.51%
========================================
Files 957 957
Lines 134553 134811 +258
Branches 11689 11754 +65
========================================
+ Hits 132551 132809 +258
Misses 2002 2002
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f2a03d6 to
33934bc
Compare
`jsdoc/no-undefined-types` resolves neither TypeScript's lib globals (`IArguments`, `ArrayLike`, `PropertyKey`, `PropertyDescriptor`, `Generator`, `ArrayBufferView`, `ReadonlyArray`) nor the `NodeJS.*` namespace. Types that relied on those names are spelled structurally or imported from `node:*` instead.
## Summary Complete parameter declarations and replace unavailable ambient type names in files added after the branch diverged. ## Why Rebasing enabled the JSDoc checks for newer master code. Without these annotations, the rebased branch cannot pass lint.
b40712f to
d4f8543
Compare
## Summary Normalize the remaining JSDoc type expressions introduced on master after the branch diverged. ## Why The enabled JSDoc checks apply to rebased master code as well.
429ad6f to
2c234e4
Compare
There was a problem hiding this comment.
More details
The diff contains no executable behavior changes: added lines are JSDoc/type annotations or lint configuration, and realistic router, OpenAI lifecycle, OTel bridge, git, and stacktrace scenarios remain passing.
📊 Validated against 4 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 2c234e4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c234e45f2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
Complete missing JSDoc parameter declarations and replace unresolved type names across instrumentation, Test Optimization, tracer, integration, and helper code. Enable
jsdoc/require-paramandjsdoc/no-undefined-types.Why
The rules were disabled behind a backlog of violations. Resolving it turns these contracts into a lint gate instead of allowing further drift.