Skip to content

argo_rollouts: add container-based config discovery support - #24506

Draft
vitkyrka wants to merge 3 commits into
graphite-base/24506from
vwhitchurch/argo_rollouts-discovery
Draft

argo_rollouts: add container-based config discovery support#24506
vitkyrka wants to merge 3 commits into
graphite-base/24506from
vwhitchurch/argo_rollouts-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to argo_rollouts.

Port selection rationale: Port 8090 is Argo Rollouts's documented default metrics port in Argo Rollouts controller-metrics docs.

Motivation

https://datadoghq.atlassian.net/browse/DSCVR-526.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 10, 2026
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-official

datadog-official Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 89.02% (+0.59%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a953b8b | Docs | Datadog PR Page | Give us feedback!

@vitkyrka
vitkyrka changed the base branch from master to vwhitchurch/keda-discovery July 10, 2026 22:07
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/keda-discovery to graphite-base/24506 July 14, 2026 14:06
vitkyrka added a commit that referenced this pull request Jul 14, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_rollouts-discovery branch from 12d5b58 to fa45b8e Compare July 14, 2026 14:07
@vitkyrka
vitkyrka force-pushed the graphite-base/24506 branch from 2c0dc75 to 9c7547f Compare July 14, 2026 14:07
@vitkyrka
vitkyrka changed the base branch from graphite-base/24506 to vwhitchurch/velero-discovery July 14, 2026 14:07

vitkyrka commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_rollouts-discovery branch 2 times, most recently from 3ffee3f to aea9deb Compare July 14, 2026 14:34
@vitkyrka
vitkyrka force-pushed the vwhitchurch/velero-discovery branch from 348bd7d to bc099c0 Compare July 15, 2026 09:03
@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_rollouts-discovery branch from aea9deb to 181ab0e Compare July 15, 2026 09:38
@vitkyrka
vitkyrka force-pushed the vwhitchurch/velero-discovery branch from bc099c0 to 9015aa7 Compare July 15, 2026 09:38
@vitkyrka vitkyrka mentioned this pull request Jul 15, 2026
3 tasks
@vitkyrka
vitkyrka force-pushed the vwhitchurch/velero-discovery branch from 9015aa7 to ac0dd17 Compare July 15, 2026 09:42
@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_rollouts-discovery branch 2 times, most recently from 1a52db8 to 643ab35 Compare July 15, 2026 10:57
@vitkyrka
vitkyrka force-pushed the vwhitchurch/velero-discovery branch from ac0dd17 to 3b1ed7c Compare July 15, 2026 10:57
vitkyrka and others added 3 commits July 16, 2026 08:07
Add a discovery strategy and auto_conf.yaml for the argo-rollouts controller
Deployment so the Agent's Kubernetes Autodiscovery listener can automatically
generate an openmetrics_endpoint configuration for it, and wire the kind-based
E2E test harness up to the new Kubernetes discovery e2e helpers
(setup_discovery_agent/save_kube_discovery_state/run_discovery_check_kubernetes/
assert_all_discovery_candidates_stable_kubernetes).

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/velero-discovery to graphite-base/24506 July 16, 2026 08:51
@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_rollouts-discovery branch from d9108eb to a953b8b Compare July 16, 2026 09:01
@vitkyrka
vitkyrka force-pushed the graphite-base/24506 branch from 7e04aa5 to c2e0447 Compare July 16, 2026 09:01
@vitkyrka
vitkyrka changed the base branch from graphite-base/24506 to vwhitchurch/velero-discovery July 16, 2026 09:01
@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
license-headers Validate Python files have proper license headers

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant