Skip to content

tekton: add container-based config discovery support - #24526

Draft
vitkyrka wants to merge 1 commit into
vwhitchurch/velero-discoveryfrom
vwhitchurch/tekton-discovery
Draft

tekton: add container-based config discovery support#24526
vitkyrka wants to merge 1 commit into
vwhitchurch/velero-discoveryfrom
vwhitchurch/tekton-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to tekton.

Known gap: the Triggers Controller's metrics endpoint (triggers_controller_endpoint, port 9000) is not covered by this PR. Its Deployment declares no containerPort on the pod spec at all — the port is only exposed via a separately-created Kubernetes Service object (confirmed both in the upstream tektoncd/triggers release manifests and on a live cluster via kubectl get pod -o yaml). The Agent's Kubelet-based Autodiscovery derives candidate ports from a pod's own declared container ports, so it never sees this port — the same class of limitation documented for Calico's own discovery attempt. Only the Pipelines Controller (which does declare a containerPort named metrics) is covered here.

AD identifier: Tekton's official release images are built with ko and published under content-hash-suffixed names (e.g. ghcr.io/tektoncd/pipeline/controller-10a3e32792f33651396d02b6855a6e36) rather than a human-readable short name. This hash is stable across releases — confirmed identical between the tektoncd/pipeline v1.0.0 and v1.14.0 GitHub release manifests — and is the exact image every real deployment applying the standard release YAML runs, so it's used verbatim as the ad_identifiers value.

Motivation

https://datadoghq.atlassian.net/browse/DSCVR-609

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 11, 2026 — with ddtool CLI
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 71.53% (-16.94%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: df9961d | Docs | Datadog PR Page | Give us feedback!

@vitkyrka
vitkyrka force-pushed the vwhitchurch/keda-discovery branch 3 times, most recently from d43155c to ade09a4 Compare July 17, 2026 13:53
vitkyrka added a commit that referenced this pull request Jul 24, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/tekton-discovery branch from 9435620 to 167dbf0 Compare July 24, 2026 08:37
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/keda-discovery to vwhitchurch/velero-discovery July 24, 2026 08:37
@vitkyrka
vitkyrka force-pushed the vwhitchurch/tekton-discovery branch 2 times, most recently from fc49944 to e380c82 Compare July 24, 2026 08:47
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/tekton-discovery branch from c7574be to df9961d Compare July 24, 2026 09:29

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation integration/tekton qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant