refactor(injector): Refactor TypeName handling and migrate to typed package#615
Merged
kakkoyun merged 3 commits intoJun 5, 2025
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 16, 2025
c56bf17 to
6c4905d
Compare
5af6ebb to
afe939a
Compare
cd7519c to
9721aaa
Compare
6c4905d to
62d099c
Compare
9721aaa to
f7476cf
Compare
62d099c to
f5ea563
Compare
This was referenced May 27, 2025
RomainMuller
approved these changes
Jun 3, 2025
131e6fc to
bbe2ed1
Compare
cbef457 to
cda266d
Compare
bbe2ed1 to
d575c0b
Compare
Base automatically changed from
kakkoyun/check-return-error-types-join-point
to
main
June 5, 2025 15:08
…ackage This commit refactors the handling of TypeName across the injector package, transitioning from the join package to a new typed package. The changes include: - Replacing instances of join.TypeName with typed.TypeName in various files, ensuring consistent type handling. - Updating related functions and methods to accommodate the new TypeName structure, including adjustments to import path retrieval and pointer handling. - Adding comprehensive tests for the new TypeName implementation to validate its functionality and error handling. This refactor enhances code clarity and maintainability by centralizing type name logic within the typed package. Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
d575c0b to
a59cbdb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
- Coverage 67.74% 66.46% -1.28%
==========================================
Files 110 110
Lines 7682 7670 -12
==========================================
- Hits 5204 5098 -106
- Misses 1925 2052 +127
+ Partials 553 520 -33
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This commit refactors the handling of TypeName across the injector package, transitioning from the join package to a new typed package. The changes include:
This refactor enhances code clarity and maintainability by centralizing type name logic within the typed package.
Signed-off-by: Kemal Akkoyun kemal.akkoyun@datadoghq.com