Skip to content

Add bfCache tracking parameter in telemetry configuration #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented May 13, 2025

Add the new tracking parameter for bfCache in rum event format telemetry

See PR

@RomanGaignault RomanGaignault requested review from a team as code owners May 13, 2025 10:40
@datadog-datadog-prod-us1
Copy link

Datadog Summary

❌ Code Quality    ✅ Code Security    ✅ Dependencies

Next Steps

Fix this code quality issue introduced by this PR:

Notice: typescript-best-practices/boolean-prop-naming
lib/cjs/generated/telemetry.d.ts:161

Consistent naming for boolean props


Was this helpful? Give us feedback!

/**
* Whether views loaded from the bfcache are tracked
*/
track_bfcache_views?: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Notice: Code Quality Violation

Prop name (track_bfcache_views) doesn't match rule (is|has) (...read more)

Enforces a consistent naming pattern for boolean props.

The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.

View in Datadog  Leave us feedback  Documentation

@RomanGaignault RomanGaignault changed the title Add telemetry for bf cache tracking Add bfCache tracking parameter in telemetry configuration May 13, 2025
Copy link

@hemeryar hemeryar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RomanGaignault RomanGaignault merged commit d148901 into master May 13, 2025
8 checks passed
@RomanGaignault RomanGaignault deleted the romanG/bf-cache-telemetry branch May 13, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants