Skip to content

Add bfCache tracking parameter in telemetry configuration #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Add bfCache tracking parameter in telemetry configuration #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/cjs/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
* Whether long tasks are tracked
*/
track_long_task?: boolean;
/**
* Whether views loaded from the bfcache are tracked
*/
track_bfcache_views?: boolean;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Notice: Code Quality Violation

Prop name (track_bfcache_views) doesn't match rule (is|has) (...read more)

Enforces a consistent naming pattern for boolean props.

The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.

View in Datadog  Leave us feedback  Documentation

/**
* Whether a secure cross-site session cookie is used (deprecated)
*/
Expand Down
4 changes: 4 additions & 0 deletions lib/esm/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
* Whether long tasks are tracked
*/
track_long_task?: boolean;
/**
* Whether views loaded from the bfcache are tracked
*/
track_bfcache_views?: boolean;
/**
* Whether a secure cross-site session cookie is used (deprecated)
*/
Expand Down
1 change: 1 addition & 0 deletions samples/telemetry-events/configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"track_session_across_subdomains": true,
"track_resources": true,
"track_long_task": true,
"track_bfcache_views": true,
"use_cross_site_session_cookie": false,
"use_secure_session_cookie": true,
"session_persistence": "cookie",
Expand Down
5 changes: 5 additions & 0 deletions schemas/telemetry/configuration-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@
"description": "Whether long tasks are tracked",
"readOnly": false
},
"track_bfcache_views": {
"type": "boolean",
"description": "Whether views loaded from the bfcache are tracked",
"readOnly": false
},
"use_cross_site_session_cookie": {
"type": "boolean",
"description": "Whether a secure cross-site session cookie is used (deprecated)"
Expand Down