Skip to content

[RUM-13793] make resource.url optional - #339

Closed
BenoitZugmeyer wants to merge 1 commit into
masterfrom
benoit/make-resource-url-optional
Closed

[RUM-13793] make resource.url optional#339
BenoitZugmeyer wants to merge 1 commit into
masterfrom
benoit/make-resource-url-optional

Conversation

@BenoitZugmeyer

Copy link
Copy Markdown
Member

On some conditions, the Browser SDK sends resource events without URL:

      DD_RUM.init({
        clientToken: 'xxx',
        applicationId: 'xxx',
        beforeSend() {},
      })
      fetch('/' + 'a'.repeat(300_000))

We'll work on a fix, but unfortunately old versions will still be around.

@BenoitZugmeyer
BenoitZugmeyer requested review from a team as code owners January 16, 2026 17:19
"type": "object",
"description": "Resource properties",
"required": ["type", "url"],
"required": ["type"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since resource.url is nullable, this change will trigger some code changes for languages where nullable type is different from non-nullable.

Will it be a permanent change? Was sending empty string or maybe not sending Resource event at all considered?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss internally

@BenoitZugmeyer

Copy link
Copy Markdown
Member Author

Resources without URLs will be dropped by the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants