Skip to content

[RUM-13793] make resource.url optional #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BenoitZugmeyer wants to merge 1 commit into from
Closed

[RUM-13793] make resource.url optional #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cjs/generated/rum.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ export declare type RumResourceEvent = CommonProperties & ActionChildProperties
/**
* URL of the resource
*/
url: string;
url?: string;
/**
* HTTP status code of the resource
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/esm/generated/rum.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ export declare type RumResourceEvent = CommonProperties & ActionChildProperties
/**
* URL of the resource
*/
url: string;
url?: string;
/**
* HTTP status code of the resource
*/
Expand Down
2 changes: 1 addition & 1 deletion schemas/rum/resource-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"resource": {
"type": "object",
"description": "Resource properties",
"required": ["type", "url"],
"required": ["type"],

@0xnm 0xnm Jan 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since resource.url is nullable, this change will trigger some code changes for languages where nullable type is different from non-nullable.

Will it be a permanent change? Was sending empty string or maybe not sending Resource event at all considered?

@BenoitZugmeyer BenoitZugmeyer Jan 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss internally

"properties": {
"id": {
"type": "string",
Expand Down
Loading