chore(dev): Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base - #2291
Conversation
|
✅ Devcontainer prebuild completed successfully. Branch: Links: |
There was a problem hiding this comment.
The new base feature moves workspace hook loading into every Zsh process, causing Saluki’s Cargo PATH hook to add duplicate entries in nested shells. Make the local ADP hook idempotent before adopting this pin.
📊 Validated against 10 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 57998b7 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
| "features": { | ||
| // Campaigner update PRs should take care of bumping those versions | ||
| "registry.ddbuild.io/workspaces/features/base:0.4.127729119": {}, | ||
| "registry.ddbuild.io/workspaces/features/base:0.4.130045754": {}, |
There was a problem hiding this comment.
Make the ADP PATH hook idempotent before this bump
Nested shells and IDE subprocess chains progressively bloat PATH with duplicate Cargo entries.
Assertion details
- Input: Start nested or repeated non-login Zsh processes after the updated feature installs Saluki’s
10-adp-workspace-env.sh. - Expected:
Workspace environment hooks should be idempotent so nested and non-login Zsh processes preserve a stable PATH. - Actual: The updated base feature sources every
*-workspace-env.shfromzshenv. Sourcing Saluki’s generated ADP hook twice produced duplicate/home/bits/.cargo/binentries. The complete fix is to make the hook generated by.devcontainer/datadog/default/features/adp/install.shprepend that directory only when absent, while retaining this version bump.
Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Binary Size Analysis (Agent Data Plane)Baseline: 470b0f0 · Comparison: bf498e0 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
…d.io/workspaces/features/base (#2291) This change is updating references to the devcontainer feature registry.ddbuild.io/workspaces/features/base tracking major version `0` to use version `0.4.130045754`. If you need more information about the reason for the update please refer to [the commit that made the change](https://github.com/ddoghq/dd-source/commit/33ad15bc8). [run-campaign] : This tag is here in case this PR updates any features whose references will then need updating. Co-authored-by: jszwedko <jesse.szwedko@datadoghq.com> 09ee189
This change is updating references to the devcontainer feature registry.ddbuild.io/workspaces/features/base tracking
major version
0to use version0.4.130045754.If you need more information about the reason for the update please refer to
the commit that made the change.
[run-campaign] : This tag is here in case this PR updates any features whose references will
then need updating.