Skip to content

chore(dev): Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base - #2291

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
engraver-auto-bump-feature-1786390258
Aug 11, 2026
Merged

chore(dev): Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base#2291
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
engraver-auto-bump-feature-1786390258

Conversation

@gh-worker-campaigns-3e9aa4

Copy link
Copy Markdown
Contributor

This change is updating references to the devcontainer feature registry.ddbuild.io/workspaces/features/base tracking
major version 0 to use version 0.4.130045754.

If you need more information about the reason for the update please refer to
the commit that made the change.
[run-campaign] : This tag is here in case this PR updates any features whose references will
then need updating.

@temporal-github-worker-1

temporal-github-worker-1 Bot commented Aug 10, 2026

Copy link
Copy Markdown

✅ Devcontainer prebuild completed successfully.

Branch: engraver-auto-bump-feature-1786390258
Config: .devcontainer/datadog/default/prebuild-devcontainer.json
Image: registry.ddbuild.io/workspaces/prebuilt/datadog/saluki@sha256:97b1772052d3a2a8cc6962746c69bf2e0fa4eb886ca752372d133a92ec44be03

⚠️ Merge the following PR(s) into your branch before merging:

Links:

@dd-octo-sts dd-octo-sts Bot changed the title Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base chore(dev): Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base Aug 10, 2026

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: WARN

The new base feature moves workspace hook loading into every Zsh process, causing Saluki’s Cargo PATH hook to add duplicate entries in nested shells. Make the local ADP hook idempotent before adopting this pin.

📊 Validated against 10 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 57998b7 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

"features": {
// Campaigner update PRs should take care of bumping those versions
"registry.ddbuild.io/workspaces/features/base:0.4.127729119": {},
"registry.ddbuild.io/workspaces/features/base:0.4.130045754": {},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Make the ADP PATH hook idempotent before this bump

Nested shells and IDE subprocess chains progressively bloat PATH with duplicate Cargo entries.

Assertion details
  • Input: Start nested or repeated non-login Zsh processes after the updated feature installs Saluki’s 10-adp-workspace-env.sh.
  • Expected: Workspace environment hooks should be idempotent so nested and non-login Zsh processes preserve a stable PATH.
  • Actual: The updated base feature sources every *-workspace-env.sh from zshenv. Sourcing Saluki’s generated ADP hook twice produced duplicate /home/bits/.cargo/bin entries. The complete fix is to make the hook generated by .devcontainer/datadog/default/features/adp/install.sh prepend that directory only when absent, while retaining this version bump.

Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@pr-commenter

pr-commenter Bot commented Aug 10, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: 470b0f0 · Comparison: bf498e0 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.51 MiB (baseline) vs 41.51 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.44a0faa3240fa409baa379409d152aec.1.llvm.8510502422222911387 +129 B 1
anon.44a0faa3240fa409baa379409d152aec.1.llvm.7053863572923731948 -129 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.8510502422222911387 +113 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.7053863572923731948 -113 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.8510502422222911387 +108 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.7053863572923731948 -108 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.8510502422222911387 +96 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.7053863572923731948 -96 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.8510502422222911387 +94 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.7053863572923731948 -94 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.8510502422222911387
  [NEW]    +113  [NEW]     +24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.8510502422222911387
  [NEW]    +108  [NEW]     +19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.8510502422222911387
  [NEW]     +96  [NEW]      +7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.8510502422222911387
  [NEW]     +94  [NEW]      +5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.8510502422222911387
  [DEL]     -94  [DEL]      -5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.7053863572923731948
  [DEL]     -96  [DEL]      -7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.7053863572923731948
  [DEL]    -108  [DEL]     -19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.7053863572923731948
  [DEL]    -113  [DEL]     -24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.7053863572923731948
  [DEL]    -129  [DEL]     -40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.7053863572923731948
  [ = ]       0  [ = ]       0    TOTAL

@pr-commenter

pr-commenter Bot commented Aug 10, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: 43a9a1c4-c532-44e0-860b-4f6dbb4054f7
Baseline: 470b0f02 · Comparison: bf498e03 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_ultraheavy memory ⚪ +0.43 metrics profiles logs
quality_gates_rss_dsd_low memory ⚪ -0.01 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.18 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ -0.19 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ -0.20 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 227 MiB ≤ 250 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 51.2 MiB ≤ 60 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 90.3 MiB ≤ 100 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 381 MiB ≤ 420 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 32.3 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 09ee189 into main Aug 11, 2026
94 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the engraver-auto-bump-feature-1786390258 branch August 11, 2026 19:13
dd-octo-sts Bot pushed a commit that referenced this pull request Aug 11, 2026
…d.io/workspaces/features/base (#2291)

This change is updating references to the devcontainer feature registry.ddbuild.io/workspaces/features/base  tracking
major version `0` to use version `0.4.130045754`.

If you need more information about the reason for the update please refer to
[the commit that made the change](https://github.com/ddoghq/dd-source/commit/33ad15bc8).
[run-campaign] : This tag is here in case this PR updates any features whose references will
then need updating.

Co-authored-by: jszwedko <jesse.szwedko@datadoghq.com> 09ee189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant