Skip to content

chore(dev): Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Aug 11, 2026
Merged

chore(dev): Update references to devcontainer feature registry.ddbuild.io/workspaces/features/base #2291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57998b7
Executing automated changes
gh-worker-campaigns-3e9aa4[bot] Aug 10, 2026
bf498e0
Merge branch 'main' into engraver-auto-bump-feature-1786390258
jszwedko Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/datadog/default/prebuild-devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"forwardPorts": [22],
"features": {
// Campaigner update PRs should take care of bumping those versions
"registry.ddbuild.io/workspaces/features/base:0.4.127729119": {},
"registry.ddbuild.io/workspaces/features/base:0.4.130045754": {},

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Make the ADP PATH hook idempotent before this bump

Nested shells and IDE subprocess chains progressively bloat PATH with duplicate Cargo entries.

Assertion details
  • Input: Start nested or repeated non-login Zsh processes after the updated feature installs Saluki’s 10-adp-workspace-env.sh.
  • Expected: Workspace environment hooks should be idempotent so nested and non-login Zsh processes preserve a stable PATH.
  • Actual: The updated base feature sources every *-workspace-env.sh from zshenv. Sourcing Saluki’s generated ADP hook twice produced duplicate /home/bits/.cargo/bin entries. The complete fix is to make the hook generated by .devcontainer/datadog/default/features/adp/install.sh prepend that directory only when absent, while retaining this version bump.

Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

"registry.ddbuild.io/workspaces/features/claude-code:0.1.123639528": {},
"registry.ddbuild.io/workspaces/features/trajectory:0.1.121704661": {},
// ADP-specific setup
Expand Down