chore(dev): simplify PR title requirements - #2329
Conversation
There was a problem hiding this comment.
More details
The label bypass is paired with labeled/unlabeled triggers, so delayed automation labels clear earlier failures and removing a bypass label rechecks the title. Repository-owned bot PRs use automated, while campaigner PR history carries campaigner-automated-change; no uncovered bot path or stale-check transition was found.
🤖 Datadog Autotest · Commit 9d21b16 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Binary Size Analysis (Agent Data Plane)Baseline: 0dee0a9 · Comparison: 9d21b16 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
| docs | ||
| revert | ||
|
|
||
| scopes: | |
There was a problem hiding this comment.
Is there any way to keep the list of scopes such that, if the optional scope is provided, it has to match one of them? My concern is we may end up with a wide variety of scopes picked by LLMs. Though, maybe this is fine 🤔
There was a problem hiding this comment.
If we specify a list at all, then yeah, that becomes the allowlist.
My reason for removing the list at all, instead of just removing the requireScope bit... is that it means we have to generate that list of allowed scopes, and that's where it gets annoying, having to either craft a suitable fixed list or have a script to generate them from a known set of rules but then making sure that list stays in sync, etc etc.
It just felt easier to remove the need for a list at all. I'm not against adding it back if LLMs go off the rails with scope choice, though.
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
Summary
As stated in the PR title.
More or less:
fix(datadog): properly do foo in Datadog forwarder, etc)In this PR, we've updated the PR title check to relax our constraints: only a type is required (
fix,enhancement, etc) and we skip the check entirely when the PR is labeled such that we determine it's a bot PR. We can still specify a scope if we want to.... and, to be clear, we should! Scopes are part of good commit message/PR description hygiene. However, we no longer require doing so. As part of that, we're now able to get rid of the supporting Make target and scripts for generating the list of accepted scopes.Likewise, we've removed the workflow for renaming bot PR titles since we just ignore the PR title check for them.
Change Type
How did you test this PR?
Merging is required before the workflow changes can be run.
References
DADP-2