Skip to content

chore(dev): simplify PR title requirements - #2329

Merged
tobz merged 1 commit into
mainfrom
tobz/simplify-pr-title-label-reqs
Aug 13, 2026
Merged

chore(dev): simplify PR title requirements#2329
tobz merged 1 commit into
mainfrom
tobz/simplify-pr-title-label-reqs

Conversation

@tobz

@tobz tobz commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

As stated in the PR title.

More or less:

  • while I love conventional/semantic PR titles, it's been somewhat cumbersome when the scope to pick is non-obvious
  • requiring a scope, even when there's only a few, can sometimes be duplicative of a well-written description portion (fix(datadog): properly do foo in Datadog forwarder, etc)
  • bot PRs throw a wrench in these requirements and have necessitated the writing of other workflows to fix them up (😓)

In this PR, we've updated the PR title check to relax our constraints: only a type is required (fix, enhancement, etc) and we skip the check entirely when the PR is labeled such that we determine it's a bot PR. We can still specify a scope if we want to.... and, to be clear, we should! Scopes are part of good commit message/PR description hygiene. However, we no longer require doing so. As part of that, we're now able to get rid of the supporting Make target and scripts for generating the list of accepted scopes.

Likewise, we've removed the workflow for renaming bot PR titles since we just ignore the PR title check for them.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

Merging is required before the workflow changes can be run.

References

DADP-2

@tobz
tobz requested a review from a team as a code owner August 13, 2026 13:47
@tobz tobz added the type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. label Aug 13, 2026
@dd-octo-sts dd-octo-sts Bot added the area/ci CI/CD, automated testing, etc. label Aug 13, 2026

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The label bypass is paired with labeled/unlabeled triggers, so delayed automation labels clear earlier failures and removing a bypass label rechecks the title. Repository-owned bot PRs use automated, while campaigner PR history carries campaigner-automated-change; no uncovered bot path or stale-check transition was found.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 9d21b16 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@pr-commenter

pr-commenter Bot commented Aug 13, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: 0dee0a9 · Comparison: 9d21b16 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.45 MiB (baseline) vs 41.45 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.44a0faa3240fa409baa379409d152aec.1.llvm.15520861671972362209 -130 B 1
anon.44a0faa3240fa409baa379409d152aec.1.llvm.5388229670196789956 +129 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.15520861671972362209 -114 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.5388229670196789956 +113 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.15520861671972362209 -109 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.5388229670196789956 +108 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.15520861671972362209 -97 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.5388229670196789956 +96 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.15520861671972362209 -95 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.5388229670196789956 +94 B 1
[Unmapped] +5 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.5388229670196789956
  [NEW]    +113  [NEW]     +24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.5388229670196789956
  [NEW]    +108  [NEW]     +19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.5388229670196789956
  [NEW]     +96  [NEW]      +7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.5388229670196789956
  [NEW]     +94  [NEW]      +5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.5388229670196789956
  +167%      +5  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.15520861671972362209
  [DEL]     -97  [DEL]      -7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.15520861671972362209
  [DEL]    -109  [DEL]     -19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.15520861671972362209
  [DEL]    -114  [DEL]     -24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.15520861671972362209
  [DEL]    -130  [DEL]     -40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.15520861671972362209
  [ = ]       0  [ = ]       0    TOTAL

docs
revert

scopes: |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to keep the list of scopes such that, if the optional scope is provided, it has to match one of them? My concern is we may end up with a wide variety of scopes picked by LLMs. Though, maybe this is fine 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we specify a list at all, then yeah, that becomes the allowlist.

My reason for removing the list at all, instead of just removing the requireScope bit... is that it means we have to generate that list of allowed scopes, and that's where it gets annoying, having to either craft a suitable fixed list or have a script to generate them from a known set of rules but then making sure that list stays in sync, etc etc.

It just felt easier to remove the need for a list at all. I'm not against adding it back if LLMs go off the rails with scope choice, though.

@pr-commenter

pr-commenter Bot commented Aug 13, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: 38a194d5-3900-4c75-8e77-9b49d04acdc1
Baseline: 0dee0a96 · Comparison: 9d21b162 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_low memory ⚪ +0.89 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ +0.32 metrics profiles logs
quality_gates_rss_idle memory ⚪ +0.12 metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory ⚪ +0.08 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ +0.07 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 232 MiB ≤ 250 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 50.9 MiB ≤ 60 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 91.1 MiB ≤ 100 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 389 MiB ≤ 420 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 31.7 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

@tobz
tobz merged commit 2ef687d into main Aug 13, 2026
99 checks passed
@tobz
tobz deleted the tobz/simplify-pr-title-label-reqs branch August 13, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD, automated testing, etc. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants