Skip to content

chore(dev): simplify PR title requirements #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobz merged 1 commit into from
Aug 13, 2026
Merged

chore(dev): simplify PR title requirements #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/chainguard/self.fix-bot-pr-title.sts.yaml
View file
Open in desktop

This file was deleted.

71 changes: 4 additions & 67 deletions .github/workflows/check-pr-title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: "Semantic PR Title Check"

on:
pull_request_target:
types: [opened, edited, synchronize]
types: [opened, edited, synchronize, labeled, unlabeled]

jobs:
main:
Expand All @@ -25,76 +25,13 @@ jobs:
env:
GITHUB_TOKEN: ${{ steps.octo-sts.outputs.token }}
with:
requireScope: true
types: |
chore
enhancement
feat
fix
docs
revert

scopes: |

@jszwedko jszwedko Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to keep the list of scopes such that, if the optional scope is provided, it has to match one of them? My concern is we may end up with a wide variety of scopes picked by LLMs. Though, maybe this is fine 🤔

@tobz tobz Aug 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we specify a list at all, then yeah, that becomes the allowlist.

My reason for removing the list at all, instead of just removing the requireScope bit... is that it means we have to generate that list of allowed scopes, and that's where it gets annoying, having to either craft a suitable fixed list or have a script to generate them from a known set of rules but then making sure that list stays in sync, etc etc.

It just felt easier to remove the need for a list at all. I'm not against adding it back if LLMs go off the rails with scope choice, though.

agent-data-plane
aggregate
airlock
antithesis
api
apm stats
app
autoscaling failover gateway
blackhole
buffered incremental
chained
checks ipc
ci
cluster agent
common
components
config
containerd-protos
context
core
correctness
datadog
datadog-agent-commons
datadog-agent-config
datadog-agent-config-overlay-model
datadog-agent-config-testing
datadog-agent-metrics-v3
datadog-intake
datadog-protos
ddsketch
deps
dev
docs
dogstatsd
dogstatsd mapper
dsd debug log
dsd stats
env
error
go-duration
heartbeat
host enrichment
integration
io
metadata
metric router
metrics
millstone
mrf gateway
o11y
otlp
otlp-protos
ottl
panoramic
process-memory
prometheus
prometheus-exposition
stele
stringtheory
test
tls
trace obfuscation
trace sampler
ignoreLabels: |
automated
campaigner-automated-change
56 changes: 0 additions & 56 deletions .github/workflows/fix-bot-pr-title.yml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,14 +956,6 @@ update-protos: ## Updates all vendored Protocol Buffers definitions from their s
SKETCHES_GO_GIT_TAG=$(PROTOBUF_SRC_REPO_SKETCHES_GO) \
./ci/tooling/update-protos.sh

.PHONY: update-pr-title-scopes
update-pr-title-scopes: ## Updates allowed PR title scopes in the CI workflow based on the codebase
@./ci/tooling/update-pr-title-scopes.sh update

.PHONY: check-pr-title-scopes
check-pr-title-scopes: ## Checks that PR title scopes in the CI workflow are up-to-date
@./ci/tooling/update-pr-title-scopes.sh check

.PHONY: clean
clean: check-rust-build-tools
clean: ## Clean all build artifacts (debug/release)
Expand Down
202 changes: 0 additions & 202 deletions ci/tooling/update-pr-title-scopes.sh
View file
Open in desktop

This file was deleted.