fix: ignoring standard_tomo and standard_tomo_diad loaders for fullpi… #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pelines for avoiding duplicate loaders in config
dkazanc
reviewed
May 13, 2025
| PIPELINES_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..", "pipelines_full") | ||
|
|
||
| ignored_methods = ["calculate_stats"] | ||
| ignored_methods = ["standard_tomo_diad","standard_tomo","calculate_stats"] |
Collaborator
There was a problem hiding this comment.
Actually there is no more such thing as standard_tomo_diad loader so you can remove it. Do you still need to ignore standard_tomo ?
Contributor
Author
There was a problem hiding this comment.
yes, cause my front-end generates standard_tomo already, both standard_tomo and calculate_stats are methods that have a different pattern compared to the rest of the methods, if I don't ignore it here the final config will have a duplicated standard_tomo method
Collaborator
There was a problem hiding this comment.
I see... well you can then do ignored_methods = ["standard_tomo","calculate_stats"]
dkazanc
reviewed
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pelines for avoiding duplicate loaders in config