Skip to content

fix: ignoring standard_tomo and standard_tomo_diad loaders for fullpi… #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

fix: ignoring standard_tomo and standard_tomo_diad loaders for fullpi… #58

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c87d71d
fix: ignoring standard_tomo and standard_tomo_diad loaders for fullpi…
itsdiy0 May 13, 2025
1786856
Update httomo_backends/scripts/json_pipelines_generator.py
dkazanc May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httomo_backends/scripts/json_pipelines_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# Directory containing YAML files relative to this script
PIPELINES_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..", "pipelines_full")

ignored_methods = ["calculate_stats"]
ignored_methods = ["standard_tomo_diad","standard_tomo","calculate_stats"]
Copy link
Collaborator

@dkazanc dkazanc May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is no more such thing as standard_tomo_diad loader so you can remove it. Do you still need to ignore standard_tomo ?

Copy link
Contributor Author

@itsdiy0 itsdiy0 May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, cause my front-end generates standard_tomo already, both standard_tomo and calculate_stats are methods that have a different pattern compared to the rest of the methods, if I don't ignore it here the final config will have a duplicated standard_tomo method

Copy link
Collaborator

@dkazanc dkazanc May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see... well you can then do ignored_methods = ["standard_tomo","calculate_stats"]


def get_yaml_path(yaml_filename: str) -> str:
"""
Expand Down