Update setup_oav to use plan moved to dodal - #1577
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
- Coverage 93.08% 93.07% -0.01%
==========================================
Files 164 164
Lines 8997 8988 -9
==========================================
- Hits 8375 8366 -9
Misses 622 622
🚀 New features to boost your workflow:
|
DominicOram
requested changes
Jan 26, 2026
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks, just the one issue
| yield from setup_general_oav_params(oav, parameters) | ||
| yield from setup_pin_tip_detection_params(pin_tip_detection_device, parameters) | ||
| yield from setup_pin_tip_detection_params( | ||
| pin_tip_detection_device, parameters, PlanGroupCheckpointConstants.READY_FOR_OAV |
Contributor
There was a problem hiding this comment.
Must: The plan you have removed does not wait at the end but the new one in dodal does by default, can you add wait=False here?
DominicOram
enabled auto-merge (squash)
January 28, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setup_pin_tip_detection_paramswas moved to dodal in 1858 so that it could be used by non-mx beamlines too. This PR updatessetup_oavto use that one.Instructions to reviewer on how to test:
setup_pin_tip_detection_paramshave been updated to use the plan in dodalChecks for reviewer