Skip to content

Conversation

@adaudon
Copy link
Contributor

@adaudon adaudon commented Jun 30, 2025

For Issue: #12
Added the three preset buttons for blueapi. Doesn't take up too much space on the screen so not sure if it's really worth creating a temporary drawer for it. Wouldn't it be easier to set a variable to hide the preset buttons on beamlines that don't use it instead of a drawer?

@adaudon adaudon requested a review from a team as a code owner June 30, 2025 09:55
@adaudon adaudon requested a review from noemifrisina June 30, 2025 09:55
Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's some issues with the OAV tab in general (see #51 - just started looking at it) which makes the placement of the buttons look weird.

Yes, they look okay now (on a full screen display at least) as far as size goes, but the problem will be that more components need to be added to this page for the alignment. These buttons instead are only used occasionally by I24 so they don't need to be always visible, so a drawer will be needed at some point - which will also be useful for other components...

It doesn't need to be done now however, but in this case please make a new issue to create one and link it in the file

@adaudon adaudon requested a review from noemifrisina July 8, 2025 15:03
Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks okay and tooltips are good, just one small thing...

@adaudon adaudon requested a review from noemifrisina July 21, 2025 09:19
Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@adaudon adaudon merged commit 2e8ca8f into main Jul 21, 2025
1 check passed
@adaudon adaudon deleted the 12-preset_buttons branch July 21, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants