-
Notifications
You must be signed in to change notification settings - Fork 0
Added preset buttons #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
noemifrisina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, there's some issues with the OAV tab in general (see #51 - just started looking at it) which makes the placement of the buttons look weird.
Yes, they look okay now (on a full screen display at least) as far as size goes, but the problem will be that more components need to be added to this page for the alignment. These buttons instead are only used occasionally by I24 so they don't need to be always visible, so a drawer will be needed at some point - which will also be useful for other components...
It doesn't need to be done now however, but in this case please make a new issue to create one and link it in the file
noemifrisina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks okay and tooltips are good, just one small thing...
noemifrisina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
For Issue: #12
Added the three preset buttons for blueapi. Doesn't take up too much space on the screen so not sure if it's really worth creating a temporary drawer for it. Wouldn't it be easier to set a variable to hide the preset buttons on beamlines that don't use it instead of a drawer?