Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Nov 20, 2025

Add data collection groups into ispyb for atlases. Each time the client sees a new atlas xml then a dcg is made.

Needs to be merged with #696

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.68%. Comparing base (6fc82bd) to head (2da2b4d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   38.23%   38.68%   +0.44%     
==========================================
  Files          97       99       +2     
  Lines       11593    11680      +87     
  Branches     1529     1546      +17     
==========================================
+ Hits         4433     4518      +85     
+ Misses       6964     6956       -8     
- Partials      196      206      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It looks good to me, and works with the expected behaviour.

@stephen-riggs stephen-riggs marked this pull request as ready for review November 21, 2025 14:40
@tieneupin
Copy link
Contributor

tieneupin commented Nov 28, 2025

We can probably close this since it was merged into PR #696.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants