Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Nov 21, 2025

Needs to merge with #695

Creates a common function for data collection group creation by the client. The data collection groups are made as atlases then updated to be SPA or Tomo if data collection happens.

Diff looks bigger than it really is as a test file got moved.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 61.81818% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.30%. Comparing base (6fc82bd) to head (796fb71).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   38.23%   39.30%   +1.06%     
==========================================
  Files          97      100       +3     
  Lines       11593    11739     +146     
  Branches     1529     1571      +42     
==========================================
+ Hits         4433     4614     +181     
+ Misses       6964     6910      -54     
- Partials      196      215      +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs stephen-riggs marked this pull request as ready for review November 26, 2025 10:07
Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. I couldn't spot anything glaringly wrong, and the pipeline works in our test setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants