refactor(appinfo)!: improve application models #695
Conversation
no functional changes
shiftinv
added
t: enhancement
shiftinv
changed the title
| @@ -1974,7 +1974,7 @@ async def fetch_widget(self, guild_id: int, /) -> Widget: | |||
| data = await self.http.get_widget(guild_id) | |||
| return Widget(state=self._connection, data=data) | |||
|
|
|||
| async def application_info(self) -> AppInfo: | |||
| async def application_info(self) -> BotAppInfo: | |||
There was a problem hiding this comment.
Might it be worth caching this information? IIRC we receive the full app info on on_ready/identify when we receive the flags of the application. If not, it may be worth caching this information anyways (due to the ext.commands extension using it anyways, and this information being quite useful regardless)
There was a problem hiding this comment.
Caching this should be up to users, since the data could change at any time - ext.commands already caches the owner/owners, which is the only part it currently needs, and the ready event only contains app ID + flags :/
shiftinv
changed the title
onerandomusername
force-pushed
the
refactor/appinfo
branch
2 times, most recently
from
d16e21f to
53aaf1b
Compare
shiftinv
force-pushed
the
refactor/appinfo
branch
from
53aaf1b to
0f0a89b
Compare
|
@shiftinv would you please resolve conflicts? |
@onerandomusername done. |
|
@shiftinv would you please resolve conflicts again? |
shiftinv
force-pushed
the
refactor/appinfo
branch
from
c5c888a to
fb557cb
Compare
Summary
Refactors application models, deduplicating and generally merging related code.
The diff is fairly unreadable as-is, skipping the first commit (that just moves
PartialAppInfoaboveAppInfo) improves readability quite a bit.tl;dr on the important changes, see changelog for everything:
PartialAppInfo < AppInfo < BotAppInfo(whereBotAppInfois equivalent to the oldAppInfo)AppInfo.summaryis no more (deprecated in previous version)Invite.target_application(which is nowAppInfo) contains more fieldscover_imageurl formatChecklist
task linttask pyright