Skip to content

refactor(appinfo)!: improve application models #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
feea395
chore: move `PartialAppInfo`
shiftinv Aug 8, 2022
6f9d573
refactor: make `AppInfo` subclass of `PartialAppInfo`
shiftinv Aug 8, 2022
c01677d
chore: sort type fields according to docs
shiftinv Aug 8, 2022
4173efb
chore!: remove application summary
shiftinv Aug 8, 2022
b0a1d3a
refactor: move fields into `PartialAppInfo`
shiftinv Aug 9, 2022
a5426bf
fix: fix application cover image urls
shiftinv Aug 9, 2022
a9c83ed
chore: remove undocumented fields from types
shiftinv Aug 9, 2022
c20352e
docs: add preliminary changelogs
shiftinv Aug 9, 2022
d0d6d5a
refactor: rename `AppInfo -> BotAppInfo`, `PartialAppInfo -> AppInfo`
shiftinv Aug 9, 2022
c1601b8
refactor: create a partial application type once again
shiftinv Aug 9, 2022
1a2d2c7
feat!: provide proper application object for `Message.application`
shiftinv Aug 9, 2022
cafe564
feat!: make `IntegrationApplication` a subclass of `PartialAppInfo`
shiftinv Aug 9, 2022
9f3454a
docs: add back missing inherited attributes
shiftinv Aug 10, 2022
fc94a7c
docs: update changelog
shiftinv Aug 10, 2022
1b797ff
docs: improve cover_image docstring
shiftinv Aug 10, 2022
cfb2f58
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Aug 23, 2022
f3c860d
docs: update version directives
shiftinv Aug 23, 2022
784e93d
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Sep 10, 2022
5fa1315
chore(docs): move to 2.7
shiftinv Sep 10, 2022
ad5d97a
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Sep 24, 2022
fb7cae9
docs: update `PartialAppInfo` changes
shiftinv Sep 24, 2022
0f0a89b
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Oct 6, 2022
b822e45
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Oct 23, 2022
6ee2eef
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Feb 23, 2023
51e6e3c
fix: update for new changes
shiftinv Feb 23, 2023
fb557cb
chore(docs): update versionadded/versionchanged
shiftinv Feb 23, 2023
69d6761
Merge remote-tracking branch 'upstream/master' into refactor/appinfo
shiftinv Apr 10, 2023
7cc826c
chore(lint): run autotyping
shiftinv Apr 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/695.breaking.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Refactor application models:
- :class:`AppInfo` now inherits from :class:`PartialAppInfo`, new type :class:`BotAppInfo` (corresponds to old ``AppInfo``) inherits from :class:`AppInfo`.
As a result of this, attributes that were previously present in :class:`PartialAppInfo` are now only in :class:`AppInfo`.
This should not have any noticeable effect unless you're instantiating these types yourself.
- Remove deprecated attributes :attr:`BotAppInfo.summary`, :attr:`AppInfo.summary`, and :attr:`IntegrationApplication.summary`.
- :attr:`AppInfo.bot_public` and :attr:`AppInfo.bot_require_code_grant` are now optional.
- :attr:`Message.application` is now a :class:`PartialAppInfo` object instead of a :class:`dict`.
- :attr:`IntegrationApplication.icon` is now an :class:`Asset`.
1 change: 1 addition & 0 deletions changelog/695.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix broken :attr:`PartialAppInfo.cover_image` url.
4 changes: 4 additions & 0 deletions changelog/695.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Improve application models:
- Add previously missing attributes to :attr:`Invite.target_application`.
- :attr:`AppInfo.rpc_origins` is no longer optional.
- Add :attr:`IntegrationApplication.cover_image`.
Loading