Fixes Backported from v22

[SylvainLegrand]

use of "MAIN_CHECKBOX_LEFT_COLUMN"
fix calculation of best supplier price

[Copilot]

Pull Request Overview

This PR backports two fixes from v22: (1) support for the MAIN_CHECKBOX_LEFT_COLUMN configuration to move action/checkbox columns to the left side of tables, and (2) correction of the best supplier price calculation to properly account for discounts when finding the minimum price.

• Added support for MAIN_CHECKBOX_LEFT_COLUMN configuration option to position action columns on the left side of supplier price tables
• Fixed best supplier price calculation to compare discounted unit prices instead of base unit prices
• Added explicit float casts to price calculations for better type safety

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
htdocs/product/fournisseurs.php	Implements conditional rendering of action/checkbox columns based on MAIN_CHECKBOX_LEFT_COLUMN configuration, allowing columns to appear on either left or right side of the supplier prices table
htdocs/fourn/class/fournisseur.product.class.php	Fixes supplier price comparison logic to use $fourn_unitprice_with_discount instead of $fourn_unitprice, ensuring discounts are properly considered when finding the minimum price

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The action parameter should be update_price instead of edit_price. The correct action is update_price as shown in the right column implementation (line 1314) and as handled by the form processing logic (line 474 where $action == 'update_price' is checked).

Suggested change

	print '<a class="editfielda" href="'.$_SERVER['PHP_SELF'].'?id='.((int) $object->id).'&socid='.((int) $productfourn->fourn_id).'&action=edit_price&token='.newToken().'&rowid='.((int) $productfourn->product_fourn_price_id).'">'.img_edit()."</a>";
	print '<a class="editfielda" href="'.$_SERVER['PHP_SELF'].'?id='.((int) $object->id).'&socid='.((int) $productfourn->fourn_id).'&action=update_price&token='.newToken().'&rowid='.((int) $productfourn->product_fourn_price_id).'">'.img_edit()."</a>";

[rycks]

i'm sorry @SylvainLegrand but we can't accept that PR : please split your contribution in two parts: one for MAIN_CHECKBOX_LEFT_COLUMN and an other one for calculation of best supplier price

thanks,
Éric