feat: component events #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ability to pass event handlers through config for common events such as onAdd
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an enhanced component event system that provides a consistent, flexible event handling mechanism for component lifecycle events. The implementation follows a pattern similar to the existing action config in dom.js, allowing developers to configure and respond to various component lifecycle events.
Key Changes:
- Added comprehensive event system to Component class with addEventListener, removeEventListener, and dispatchComponentEvent methods
- Integrated event dispatching into lifecycle methods (onAdd, onRemove, addChild, onRender, clone, and data updates)
- Maintained full backwards compatibility with existing event handlers
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/js/components/component.js | Core implementation of event system including Map-based event storage, event dispatching, and lifecycle integration |
| src/lib/js/components/component-events.test.js | Test suite covering event initialization, add/remove listeners, dispatching, error handling, and update events |
| src/lib/js/components/panels.js | Added radix parameter to parseInt for proper number parsing |
| src/lib/js/common/dom.js | Removed unused conditions variable from destructuring |
| src/demo/js/options/enhanced-config-example.js | Comprehensive example demonstrating new event system capabilities |
| src/demo/js/options/config.js | Updated to use new event system with enhanced onAdd handler |
| docs/component-events.md | Complete documentation of event system including API reference and migration guide |
| docs/README.md | Added link to component events documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Collaborator
Author
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ability to pass event handlers through config for common events such as onAdd
resolves #381 #348 #279