Updates to sea ice bgc registry and history fields #6644
Conversation
-Corrects units/descriptions of bgc fields in registry -Defines column integrated and cell average bgc diagnostics -Updates streams build to include new diagnostics for bgc runs BFB
|
|
@njeffery What kinds of testing have you done on these changes? We need to confirm BFB with the current code and that all of the new fields and diagnostics have reasonable (hopefully correct) output in them. Is there a possibility that runs with some BGC options on and other options off could have misleading or NaN output? |
|
@eclare108213 : I've done a very short 2X5 day ocean-ice with bgc+zaerosols test to verify restartability and BFB. I've also plotted the new diagnostics to verify that they're corrected. I believe the standard checks verify bfb in the physics configuration but @jonbob can confirm. There is a possibility that bgc on and zaerosols off will produce Nans in some fields. Let me fix that. |
|
@eclare108213 : I've completed a test with zaerosols off and bgc active to verify no NaNs. I also plotted ocean surface bgc fields and the new sea ice 2D bgc diagnostics to make sure the order of magnitudes are consistent. All the new fields looked consistent. Here's a couple of examples: Sea ice Algal Carbon totalVerticalAlgaeCarbonIce-4.pdf Ocean surface diatom carbon Sea ice nitrate Ocean surface nitrate |
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
This PR only affects output of BGC quantities. I am approving based on developer testing. @jonbob will run the complete E3SM test suite to verify there are no other impacts.
Updates to sea ice bgc registry and history fields Several changes including: * Corrects units/descriptions of bgc fields in registry * Defines column integrated and cell average bgc diagnostics * Updates streams build to include new diagnostics for bgc runs [BFB]
|
Passes:
merged to next |
|
merged to master |
-Corrects units/descriptions of bgc fields in registry
-Defines column integrated and cell average bgc diagnostics
-Updates streams build to include new diagnostics for bgc runs
[BFB]