Skip to content

Conversation

@glemieux
Copy link
Contributor

This update provides FATES with insight into the nutrient supplementation modes. This work is driven by changes per NGEET/fates#1353 and as such should be coordinated with that pull request.

@glemieux glemieux requested a review from rgknox March 27, 2025 23:55
@glemieux glemieux changed the title Add call to set fates control parameters for nutrient supplementation Add call to set FATES control parameters for nutrient supplementation Mar 27, 2025
@glemieux glemieux moved this to Finding Reviewers in FATES Pull Request Planning and Status Mar 27, 2025
@glemieux
Copy link
Contributor Author

glemieux commented May 5, 2025

This update provides FATES with insight into the nutrient supplementation modes. This work is driven by changes per NGEET/fates#1353 and as such should be coordinated with that pull request.

Tecnically, this just needs to come in prior to NGEET/fates#1353. They should be tested together to confirm intent, but this is otherwise ready for review.

@glemieux glemieux marked this pull request as ready for review May 5, 2025 18:05
@glemieux glemieux moved this to Finding Reviewers in FATES Pull Request Planning and Status May 5, 2025
@rljacob rljacob added FATES ELM land model labels May 5, 2025
@rljacob
Copy link
Member

rljacob commented May 15, 2025

@rgknox please review

@glemieux glemieux moved this from Finding Reviewers to Under Review in FATES Pull Request Planning and Status May 15, 2025
@glemieux
Copy link
Contributor Author

@rgknox I found a circular dependency that's going to require a little more work to untangle. So please hold on the review.

@rljacob would you change this back to a draft please?

@peterdschwartz peterdschwartz marked this pull request as draft May 15, 2025 23:25
@glemieux glemieux moved this from Under Review to Stuck in FATES Pull Request Planning and Status May 20, 2025
@rgknox
Copy link
Contributor

rgknox commented Jul 23, 2025

@glemieux can you take a look at PR #7542 and close this if/when you deem appropriate?

@glemieux
Copy link
Contributor Author

closing per #7542

@glemieux glemieux closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ELM land model FATES

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants