Adding nutrient supplementation status to arguments in FATES dynamics #7542
+23
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR should supplant #7182. |
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
glemieux
approved these changes
Jul 28, 2025
glemieux
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
Contributor
|
This is still waiting on that FATES PR ? |
Contributor
Author
|
Yes @peterdschwartz , this needs to follow the FATES PR: NGEET/fates#1443 |
rgknox
changed the title
glemieux
moved this from Under Review
to Stuck
in FATES Pull Request Planning and Status
Member
|
notes: still waiting on testing on FATES side. |
Member
|
update: still waiting on testing on FATES side. |
glemieux
force-pushed
the
rgknox/lnd/fates-l2fr-info
branch
from
4566e37 to
5488af3
Compare
glemieux
moved this from Hold
to Final Testing
in FATES Pull Request Planning and Status
Contributor
|
Regression testing underway on perlmutter |
glemieux
moved this from Final Testing
to Ready to Integrate
in FATES Pull Request Planning and Status
Contributor
|
Testing with the e3sm_land_developer on perlmutter againt |
Contributor
|
testing on chrysalis merged to next came back as expected so will merge asap. |
peterdschwartz
added a commit
that referenced
this pull request
Nov 5, 2025
FATES plant dynamically regulate fineroots in the presence of nutrient limitations. However it is only appropriate to enable this regulation when the soil is not being supplemented with nutrients. This set of changes makes it so that supplementation status is passed to fates prior to its daily dynamics call, which is ideal since supplementation status can change mid run. Collaborators: @sharma-bharat @glemieux @walkeranthonyp @dmricciuto [non-BFB] Fates Only
Contributor
|
merged to next |
Contributor
|
merged to master |
|
This is great news! Thank you everyone for working on it and your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FATES plant dynamically regulate fineroots in the presence of nutrient limitations.
However it is only appropriate to enable this regulation when the soil is not being supplemented with nutrients.
This set of changes makes it so that supplementation status is passed to fates prior to its daily dynamics call, which is ideal since supplementation status can change mid run.
Collaborators:
@sharma-bharat @glemieux @walkeranthonyp @dmricciuto
[non-BFB] Fates Only