Some cleanup and bfb fixes in EAMxx gw #7827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
added
BFB
rljacob
changed the title
tcclevenger
approved these changes
Oct 23, 2025
jgfouca
added a commit
that referenced
this pull request
Oct 23, 2025
Some cleanup and bfb fixes in EAMxx gw. Change list: 1) Remove redundant gw_ from file names 2) Move all constants into constant struct in Functions 3) Add a tol for some front bfb unit tests 4) Another small EKAT update to bring in h2d|d2h improvements. This should fix CI issues with small round-off-level diffs. [BFB] * jgfouca/gw_cleanup_round: GPU didn't like this constant for some reason Go ahead and update EKAT too Tol needed in a couple places A last round of easy cleanup for the GW port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list:
gw_from file namesThis should fix CI issues with small round-off-level diffs.
[BFB]