EAM: Improves error messages in modal_aer_opt.F90 #7879
Conversation
singhbalwinder
added
BFB
There was a problem hiding this comment.
Pull Request Overview
This PR improves error messages in modal_aer_opt.F90 to provide more detailed diagnostic information when aerosol optical depth errors occur, making it easier to debug crashes.
Key changes:
- Replaced generic error messages with detailed messages that include the specific value of
dopaer(i)causing the error - Added
error_strvariable to construct comprehensive error messages with file/line information
Comments suppressed due to low confidence (1)
components/eam/src/physics/cam/modal_aer_opt.F90:1146
- The condition has been hardcoded to
.true., which will cause this error-checking block to execute unconditionally for every iteration. This should be reverted to the original condition(dopaer(i) <= -1.e-10_r8) .or. (dopaer(i) >= 30._r8)to only trigger when actual errors occur.
if ((dopaer(i) <= -1.e-10_r8) .or. (dopaer(i) >= 30._r8)) then
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
singhbalwinder
changed the title
|
@rljacob : The error message automatically includes "ERROR" in itself when we call |
|
|
||
| nerr_dopaer = nerr_dopaer + 1 | ||
| if (dopaer(i) < -1.e-10_r8) then | ||
| write(error_str, *) 'ERROR: dopaer(', i, ')=', dopaer(i) ,' which is < -1.e-10_r8 (negative aerosol optical depth) in ',& |
There was a problem hiding this comment.
It is ok to have ERROR appear twice. Please put it back. When searching the log, I want to find this message by searching for ERROR.
There was a problem hiding this comment.
I have added the "ERROR" string back to the error messages.
Improves error messages in modal_aer_opt.F90 to provide more detailed diagnostic information when aerosol optical depth errors occur, making it easier to debug crashes.
Key changes:
Replaced generic error messages with detailed messages that include the specific value of dopaer(i) causing the error
Added error_str variable to construct comprehensive error messages with file/line information
Fixes #7877
[BFB]