Skip to content

EAM: Improves error messages in modal_aer_opt.F90 #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+11 −5
Open

EAM: Improves error messages in modal_aer_opt.F90 #7879

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2ec999
EAM: Fixes error messages in modal_aer_opt.F90
singhbalwinder Nov 12, 2025
97df40f
Fixed debugging conditionals
singhbalwinder Nov 12, 2025
c98ac4c
Removes "Error" as it is automatically added by endrun
singhbalwinder Nov 12, 2025
f7804e9
Adds ERROR string back to the error messages
singhbalwinder Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions components/eam/src/physics/cam/modal_aer_opt.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,7 @@ subroutine modal_aero_sw(list_idx, dt, state, pbuf, nnite, idxnite, is_cmip6_vol
! stratosphere output
integer :: ihuge ! a huge integer
real(r8) :: saodvis(pcols) ! stratosphere extinction optical depth
character(len=256) :: error_str
!----------------------------------------------------------------------------

lchnk = state%lchnk
Expand Down Expand Up @@ -1170,10 +1171,10 @@ subroutine modal_aero_sw(list_idx, dt, state, pbuf, nnite, idxnite, is_cmip6_vol
end do

nerr_dopaer = nerr_dopaer + 1
! if (nerr_dopaer >= nerrmax_dopaer) then
if (dopaer(i) < -1.e-10_r8) then
write(iulog,*) '*** halting in '//subname//' after nerr_dopaer =', nerr_dopaer
call endrun('exit from '//subname)
write(error_str, *) 'dopaer(', i, ')=', dopaer(i) ,' which is < -1.e-10_r8 (negative aerosol optical depth) in ',&
trim(subname),' [',trim(errmsg(__FILE__, __LINE__)),']'
call endrun(trim(error_str))
end if

end if
Expand Down Expand Up @@ -1423,6 +1424,7 @@ subroutine modal_aero_lw(list_idx, dt, state, pbuf, tauxar, clear_rh)
real(r8) :: volf ! volume fraction of insoluble aerosol

character(len=*), parameter :: subname = 'modal_aero_lw'
character(len=256) :: error_str
!----------------------------------------------------------------------------

lchnk = state%lchnk
Expand Down Expand Up @@ -1578,8 +1580,12 @@ subroutine modal_aero_lw(list_idx, dt, state, pbuf, tauxar, clear_rh)

nerr_dopaer = nerr_dopaer + 1
if (nerr_dopaer >= nerrmax_dopaer .or. dopaer(i) < -1.e-10_r8) then
write(iulog,*) '*** halting in '//subname//' after nerr_dopaer =', nerr_dopaer
call endrun()
write(error_str,*) &
'Maximum number of aerosol optical depth errors exceeded (nerrmax_dopaer = ', &
nerrmax_dopaer, ') - OR - dopaer(', i, ') = ', dopaer(i), ' which is < -1.e-10_r8 in ', &
trim(subname), ' [', trim(errmsg(__FILE__, __LINE__)),']'

call endrun(trim(error_str))
end if

end if
Expand Down