EAM: Improves error messages in modal_aer_opt.F90 #7879
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhbalwinder
added
BFB
Copilot finished reviewing on behalf of
singhbalwinder
November 12, 2025 15:55
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error messages in modal_aer_opt.F90 to provide more detailed diagnostic information when aerosol optical depth errors occur, making it easier to debug crashes.
Key changes:
- Replaced generic error messages with detailed messages that include the specific value of
dopaer(i)causing the error - Added
error_strvariable to construct comprehensive error messages with file/line information
Comments suppressed due to low confidence (1)
components/eam/src/physics/cam/modal_aer_opt.F90:1146
- The condition has been hardcoded to
.true., which will cause this error-checking block to execute unconditionally for every iteration. This should be reverted to the original condition(dopaer(i) <= -1.e-10_r8) .or. (dopaer(i) >= 30._r8)to only trigger when actual errors occur.
if ((dopaer(i) <= -1.e-10_r8) .or. (dopaer(i) >= 30._r8)) then
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
singhbalwinder
changed the title
Contributor
Author
|
@rljacob : The error message automatically includes "ERROR" in itself when we call |
rljacob
reviewed
Nov 12, 2025
|
|
||
| nerr_dopaer = nerr_dopaer + 1 | ||
| if (dopaer(i) < -1.e-10_r8) then | ||
| write(error_str, *) 'ERROR: dopaer(', i, ')=', dopaer(i) ,' which is < -1.e-10_r8 (negative aerosol optical depth) in ',& |
Member
There was a problem hiding this comment.
It is ok to have ERROR appear twice. Please put it back. When searching the log, I want to find this message by searching for ERROR.
Contributor
Author
There was a problem hiding this comment.
I have added the "ERROR" string back to the error messages.
rljacob
approved these changes
Nov 12, 2025
singhbalwinder
added a commit
that referenced
this pull request
Nov 13, 2025
#7879) EAM: Improves error messages in modal_aer_opt.F90 Improves error messages in modal_aer_opt.F90 to provide more detailed diagnostic information when aerosol optical depth errors occur, making it easier to debug crashes. Key changes: Replaced generic error messages with detailed messages that include the specific value of dopaer(i) causing the error Added error_str variable to construct comprehensive error messages with file/line information Fixes #7877 [BFB] * singhbalwinder/atm/fix-error-msg-modal_opt: Adds ERROR string back to the error messages Removes "Error" as it is automatically added by endrun Fixed debugging conditionals EAM: Fixes error messages in modal_aer_opt.F90
Contributor
Author
|
on next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error messages in modal_aer_opt.F90 to provide more detailed diagnostic information when aerosol optical depth errors occur, making it easier to debug crashes.
Key changes:
Replaced generic error messages with detailed messages that include the specific value of dopaer(i) causing the error
Added error_str variable to construct comprehensive error messages with file/line information
Fixes #7877
[BFB]