Skip to content

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Oct 1, 2025

Summary

Objectives:

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Oct 1, 2025
@forsyth2 forsyth2 added DevOps CI/CD, configuration, etc. semver: bug Bug fix (will increment patch version) labels Oct 1, 2025
@forsyth2 forsyth2 mentioned this pull request Oct 1, 2025
7 tasks
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Oct 2, 2025

@tomvothecoder @xylar Can one of you let me know if this is good to merge? Thanks!

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We'll add it back with the docs.

@tomvothecoder
Copy link

From what I understand, the publish-docs section fails because the docs infrastructure isn't actually set up yet.

If so, disabling it makes sense to me.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Oct 2, 2025

fails because the docs infrastructure isn't actually set up yet

Yes, correct.

@forsyth2 forsyth2 merged commit 98fa8dc into main Oct 2, 2025
5 checks passed
@forsyth2 forsyth2 deleted the fix-conda-docs branch October 2, 2025 23:44
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Oct 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevOps CI/CD, configuration, etc. semver: bug Bug fix (will increment patch version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants