-
Notifications
You must be signed in to change notification settings - Fork 2
Update Python support #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Testinglcrc_conda
cd ~/ez/zppy-interfaces
git fetch upstream main
git status
# Check for uncommitted changes
git checkout -b update-python upstream/main
git grep -n python
# Make changes to support python3.11+
rm -rf build
conda clean --all --y
conda env create -f conda/dev.yml -n zi-py-3-11-20250916
conda activate zi-py-3-11-20250916
pre-commit run --all-files
python -m pip install .
pytest tests/unit/global_time_series/test_*.py
# 10 passed in 32.19s
git commit -m "Update Python support" |
|
This latest commit works on 3.11, 3.12, and 3.13 However, I tried the following from and updated That produced this diff: Which ultimately causes the |
The versions of packages from I will take a look at the specifics but I would try to update the versions to be as new as possible as part of this PR. |
|
It appears that black 25.9.0 has not yet been built on conda-forge: It looks like isort 6.0.1 is available: The latest I do not think you use flake8-isort, so this maybe can be removed from the conda dev envrionment. You were switching to: While the |
|
Let's get this straightened out first, then I'll review E3SM-Project/zppy#735 (and E3SM-Project/zstash#384 if you like). |
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Great, I'll merge this then.
Yes, that would be helpful. Thank you! |
Summary
Objectives:
Select one: This pull request is...
Small Change