Update Python support #735

forsyth2 · 2025-09-16T22:49:32Z

Summary

Equivalent of Update Python support zstash#384, Update Python support zppy-interfaces#33

Objectives:

Update Python support to 3.11+

Select one: This pull request is...

a bug fix: increment the patch version
a small improvement: increment the minor version
a new feature: increment the minor version
an incompatible (non-backwards compatible) API change: increment the major version

Small Change

To merge, I will use "Squash and merge". That is, this change should be a single commit.
Logic: I have visually inspected the entire pull request myself.
Pre-commit checks: All the pre-commits checks have passed.

forsyth2 · 2025-09-16T23:20:55Z

Testing

lcrc_conda
cd ~/ez/zppy
git fetch upstream main
git status
# Check for uncommitted changes
git checkout -b update-python upstream/main
git grep -n python
# Make changes to support python3.11+
rm -rf build
conda clean --all --y
conda env create -f conda/dev.yml -n zppy-py-3-11-20250916
conda activate zppy-py-3-11-20250916
pre-commit run --all-files
python -m pip install .
pytest tests/test_*.py
# 25 passed
git add -A
git commit -m "Update Python support"

forsyth2 · 2025-09-25T16:20:09Z

.github/workflows/build_workflow.yml

          path: ~/conda_pkgs_dir
          key: ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
-            hashFiles('conda/dev.yml') }}
+            hashFiles('conda/dev.yml') }}}-python${{ matrix.python-version }}


Remove 3rd }

xylar · 2025-09-25T16:21:04Z

@forsyth2 , please add me as a reviewer when this is ready for review.

forsyth2 · 2025-09-25T16:22:32Z

.github/workflows/build_workflow.yml

-          channel-priority: strict
+          channel-priority: flexible # Changed from strict to flexible
          auto-update-conda: true
+          python-version: "3.11" # Use stable Python version for docs


Change to 3.13

forsyth2 · 2025-09-25T16:31:10Z

conda/dev.yml

+  - docutils>=0.16    # Removed <0.17 constraint
  # Quality Assurance Tools
  # =======================
  # If versions are updated, also update 'rev' in `.pre-commit-config.yaml`


Do this: "If versions are updated, also update 'rev' in .pre-commit-config.yaml"

The autoupdate didn't seem to work for zppy-interfaces: E3SM-Project/zppy-interfaces#33 (comment), so I didn't do it here either.

forsyth2 · 2025-09-25T17:28:06Z

@tomvothecoder Thanks for reviewing E3SM-Project/zstash#384. Can you also take a look at this PR for zppy as well as zppy-interface's E3SM-Project/zppy-interfaces#33? For both, I'm a little confused if the pre-commit packages have the right versions. There's a lot to coordinate!!

@xylar also tagging you for review, since you requested. Thanks!

xylar · 2025-10-01T19:05:37Z

conda/dev.yml

+  - black >=24.0.0
+  - flake8 >=7.0.0
  # This line also implicitly installs isort
-  - flake8-isort=6.1.1  # version from https://anaconda.org/conda-forge/flake8-isort
-  - mypy=1.11.2         # version from https://anaconda.org/conda-forge/mypy
-  - pre-commit=4.0.1    # version from https://anaconda.org/conda-forge/pre-commit
-  - tbump=6.9.0
+  - flake8-isort >=6.0.0
+  - mypy >=1.11.0
+  - pre-commit >=4.0.0


Same suggestion here. Use the latest versions and pin them with ==, just like in zppy-interfaces.

I suggest that you update .pre-commit-config.yaml as well in this PR.

Addressed in c108327. Looks like it's passing 3.11, 3.12, 3.13.

xylar · 2025-10-01T19:08:47Z

setup.py

A note for the near future: consider moving to a pyproject.toml.

I can take this on once this PR goes in. It's pretty trivial with copilot.

xylar · 2025-10-01T19:38:06Z

One more place to update:
https://github.com/E3SM-Project/zppy/blob/main/pyproject.toml#L7

I don't know if this should be python 3.11 (the lowest supported version) or python 3.13 (the highest). What is being done elsewhere, @tomvothecoder?

xylar · 2025-10-01T20:18:14Z

conda/dev.yml

+  - tbump >=6.9.0
  # Developer Tools
  # =======================
  - tbump=6.9.0


This is listed twice:

Suggested change

- tbump=6.9.0

tomvothecoder · 2025-10-01T21:39:31Z

One more place to update: main/pyproject.toml#L7

I don't know if this should be python 3.11 (the lowest supported version) or python 3.13 (the highest). What is being done elsewhere, @tomvothecoder?

There isn't a set guideline on what this should be (min, max, or range). I decided to go with the min supported Python when I was using black.

forsyth2 · 2025-10-01T21:43:11Z

I decided to go with the min supported Python

So does that mean change target-version = ['py36'] to target-version = ['py311']?

forsyth2 · 2025-10-01T23:42:56Z

This is listed twice:
I decided to go with the min supported Python

@xylar @tomvothecoder I addressed these comments in 4c5f285. The GitHub Actions are passing for 3.11, 3.12, 3.13. Is this good to merge?

xylar

Looks right to me!

tomvothecoder

LGTM

Update Python support

086eb67

forsyth2 self-assigned this Sep 16, 2025

forsyth2 added the DevOps CI/CD, configuration, etc. label Sep 16, 2025

This was referenced Sep 16, 2025

Update Python support E3SM-Project/zppy-interfaces#33

Merged

Update Python support E3SM-Project/zstash#384

Merged

forsyth2 added 2 commits September 25, 2025 10:23

Match latest zstash python support

4a2caf9

Fixes try 2

1a8dd28

forsyth2 commented Sep 25, 2025

View reviewed changes

Further updates

bfb4e01

forsyth2 marked this pull request as ready for review September 25, 2025 17:24

forsyth2 requested review from tomvothecoder and xylar September 25, 2025 17:28

forsyth2 mentioned this pull request Sep 26, 2025

Zppy pcmdi 202505 rev #732

Merged

xylar reviewed Oct 1, 2025

View reviewed changes

Address comments

c108327

xylar reviewed Oct 1, 2025

View reviewed changes

Address further comments

4c5f285

xylar approved these changes Oct 2, 2025

View reviewed changes

xylar mentioned this pull request Oct 2, 2025

Switch to pyproject.toml #739

Merged

7 tasks

tomvothecoder approved these changes Oct 2, 2025

View reviewed changes

forsyth2 merged commit 9b8c9ab into main Oct 2, 2025
6 checks passed

forsyth2 deleted the update-python branch October 2, 2025 19:14

Update Python support #735

Update Python support #735

Uh oh!

Conversation

forsyth2 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Small Change

Uh oh!

forsyth2 commented Sep 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xylar commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

forsyth2 Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

forsyth2 Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

forsyth2 commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xylar commented Oct 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomvothecoder commented Oct 1, 2025

Uh oh!

forsyth2 commented Oct 1, 2025

Uh oh!

forsyth2 commented Oct 1, 2025

Uh oh!

xylar left a comment

Choose a reason for hiding this comment

Uh oh!

tomvothecoder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

forsyth2 commented Sep 16, 2025 •

edited

Loading

forsyth2 Sep 25, 2025 •

edited

Loading

forsyth2 Sep 25, 2025 •

edited

Loading