Skip to content

Test fixes#769

Merged
forsyth2 merged 1 commit intomainfrom
test-fixes
Mar 5, 2026
Merged

Test fixes#769
forsyth2 merged 1 commit intomainfrom
test-fixes

Conversation

@forsyth2
Copy link
Copy Markdown
Collaborator

Summary

Objectives:

  • Make legacy 3.1.0 references consistent with 3.0.0
  • Always run land_monthly subtask, as it's needed by e3sm_diags AND ilamb

Issue resolution:

  • Resolves issues noted here (incorrect legacy 3.1.0 setup) & here (incorrect activation command for land_monthly)

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Dec 19, 2025
@forsyth2 forsyth2 added semver: bug Bug fix (will increment patch version) Testing Files in `tests` modified labels Dec 19, 2025
@forsyth2
Copy link
Copy Markdown
Collaborator Author

forsyth2 commented Dec 30, 2025

Another fix to add: don't delete test_campaign output directories at the end of each test. That's causing issues with updating the expected results.
E.g.,:

# assert os.system("rm -r test_campaign_water_cycle_override_output") == 0

EDIT: test_defaults.py could also use this fix.

- Make legacy 3.1.0 references consistent with 3.0.0
- Always run land_monthly subtask, as it's needed by e3sm_diags AND ilamb
@forsyth2
Copy link
Copy Markdown
Collaborator Author

Commit 2 needed while testing #774.

@forsyth2
Copy link
Copy Markdown
Collaborator Author

forsyth2 commented Mar 5, 2026

I removed Commit 2 since it was determined to be unnecessary. In #774 (comment):

I had extended the time limit here because it was hitting the time limit, but it turns out the time limit isn't the problem at all. The job stays active even after the segmentation fault, but doesn't actually do anything to recover from it.

@forsyth2
Copy link
Copy Markdown
Collaborator Author

forsyth2 commented Mar 5, 2026

I think this is ready to merge. I've tested the primary (and now only) commit while testing multiple other PRs. Furthermore, #772 will be incorporating changes to the v3 test cfg, so we should now enable the 3.1.0 legacy test cfgs (which this commit does). That is, the primary test cfg will soon diverge from the 3.1.0 legacy test cfg, so it will actually be important to test both.

@forsyth2 forsyth2 marked this pull request as ready for review March 5, 2026 18:59
@forsyth2 forsyth2 merged commit 833c3e4 into main Mar 5, 2026
7 checks passed
@forsyth2 forsyth2 deleted the test-fixes branch March 5, 2026 18:59
@forsyth2 forsyth2 mentioned this pull request Mar 5, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: bug Bug fix (will increment patch version) Testing Files in `tests` modified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant