-
Notifications
You must be signed in to change notification settings - Fork 10
Improve tests #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is almost exclusively test changes. Since we are in the E3SM Unified testing period, and iteratively updating tests accordingly, I'm just going to go ahead and merge this.
The only non-testing attribute changed is that the permissible versions of globus-sdk needed an upper bound to pass tests. As such, I will make a zstash rc3 after merging this PR.
| - sqlite | ||
| - six >=1.16.0 | ||
| - globus-sdk >=3.15.0 | ||
| - globus-sdk >=3.15.0,<4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, we get AttributeError: 'TransferClient' object has no attribute 'endpoint_autoactivate'
| # for new auth credentials in case they have expired: | ||
| if [[ $# -gt 1 ]]; then | ||
| if [[ $2 == "NEW_CREDS" ]]: then | ||
| rm -f ~/.globus-native-apps.cfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is no longer used, as of #380.
Summary
This PR better structures existing tests, so it is clearer how to run each of them. It is not significantly changing what we're testing.
Objectives:
try_#paths)pytest(The tests intests/integration/python_testswill require more effort to convert over).condasetup accordingly to get tests working.Issue resolution:
Select one: This pull request is...
Small Change