Skip to content

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Jun 6, 2025

Description of changes

Adds a GitHub workflow job that runs our Python unit tests whenever a relevant file is changed. Required some changes to unit tests to ensure portability, including one being changed to a system test—we'll deal with making that portable later.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: As of bd695ac:

  • Python unit tests pass on my Mac
  • New GitHub Workflow to run Python unit tests passes
  • Python unit testing on Derecho passes
  • Python system testing on Derecho passes
  • clm_pymods suite passes: /glade/derecho/scratch/samrabin/tests_0626-162704de/

@samsrabin samsrabin self-assigned this Jun 6, 2025
@samsrabin samsrabin added testing additions or changes to tests bfb bit-for-bit test: python Pass clm_pymods test suite plus Python sys/unit tests before merging devops Development Operations to improve development throughput, E.g., adding GitHub Workflows labels Jun 6, 2025
@samsrabin samsrabin changed the base branch from master to b4b-dev June 6, 2025 21:07
@samsrabin samsrabin linked an issue Jun 6, 2025 that may be closed by this pull request
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 6, 2025
@samsrabin samsrabin marked this pull request as ready for review June 6, 2025 21:23
@samsrabin samsrabin changed the title [WIP] Add GitHub workflow for Python unit tests Add GitHub workflow for Python unit tests Jun 7, 2025
@samsrabin samsrabin added PR status: awaiting review Work on this PR is paused while waiting for review. PR status: needs testing labels Jun 9, 2025
@rgknox
Copy link
Collaborator

rgknox commented Jun 9, 2025

totally awesome feature @samsrabin

@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jun 26, 2025
@samsrabin samsrabin moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Jun 26, 2025
@samsrabin samsrabin removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jun 26, 2025
@samsrabin samsrabin requested a review from slevis-lmwg June 26, 2025 21:55
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin thank you for the intro to github workflows.
@samsrabin and I went over this PR in detail today.

@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Jun 27, 2025
@samsrabin samsrabin merged commit c1c9a3d into ESCOMP:b4b-dev Jun 27, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit devops Development Operations to improve development throughput, E.g., adding GitHub Workflows PR status: awaiting review Work on this PR is paused while waiting for review. test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests

Projects

Status: Done (non release/external)

3 participants