-
Notifications
You must be signed in to change notification settings - Fork 341
Add GitHub workflow for Python unit tests #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last step needed to make it so that UNIT tests are portable to machines other than those defined in CESM, and thus: Resolves ESCOMP#2984.
Since they were working on the same triggers.
Collaborator
|
totally awesome feature @samsrabin |
samsrabin
commented
Jun 20, 2025
This was
linked to
issues
Jun 26, 2025
slevis-lmwg
approved these changes
Jun 27, 2025
Contributor
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin thank you for the intro to github workflows.
@samsrabin and I went over this PR in detail today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bfb
bit-for-bit
devops
Development Operations to improve development throughput, E.g., adding GitHub Workflows
PR status: awaiting review
Work on this PR is paused while waiting for review.
test: python
Pass clm_pymods test suite plus Python sys/unit tests before merging
testing
additions or changes to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a GitHub workflow job that runs our Python unit tests whenever a relevant file is changed. Required some changes to unit tests to ensure portability, including one being changed to a system test—we'll deal with making that portable later.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: As of bd695ac:
clm_pymodssuite passes:/glade/derecho/scratch/samrabin/tests_0626-162704de/