Skip to content

Conversation

@ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Jul 9, 2025

Description of changes

Add a new testlist decomp_init and add some extra PE layouts for: ne120 and mpasa15

Specific notes

Contributors other than yourself, if any: John Dennis

CTSM Issues Fixed (include github issue #):
Fixes #3312

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)?
Allows ne120 and mpas15 grids to have additional PE layout "sizes": XL, L, M, S, XS for ne120, and L, S, XS for mpasa15

Does this create a need to change or add documentation? Did you do so? No n/a

Testing performed, if any: ran decomp_init testlist

IMPORTANT NOTE: This DOES CHANGE ANSWERS for the one self-test.
I should have caught this and as such shouldn't have merged to b4b-dev.
But, this self-test is a different beast and changes to answers there don't really matter.

The test that changes is:

    SMS_D_Ln1.f10_f10_mg37.I2000Clm50BgcCropQianRs.derecho_intel.clm-run_self_tests

 The fields that change are:
 RMS lndImp_Fall_evap                 4.0408E-06            NORMALIZED  1.8816E-01
 RMS lndImp_Fall_lat                  1.1481E+01            NORMALIZED  1.8864E-01
 RMS lndImp_Fall_lwup                 8.1192E+00            NORMALIZED  3.0125E-02
 RMS lndImp_Fall_sen                  3.0676E+01            NORMALIZED  4.1299E-01
 RMS lndImp_Fall_swnet                1.2477E+00            NORMALIZED  1.0133E-02
 RMS lndImp_Fall_taux                 5.5936E-03            NORMALIZED  1.3070E-01
 RMS lndImp_Fall_tauy                 5.5936E-03            NORMALIZED  1.3070E-01
 RMS lndImp_Sl_anidf                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_anidr                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_avsdf                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_avsdr                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_fv                     6.0521E-03            NORMALIZED  3.1427E-02
 RMS lndImp_Sl_qref                   3.7818E-05            NORMALIZED  9.6302E-03
 RMS lndImp_Sl_ram1                   1.0268E+01            NORMALIZED  5.0912E-02
 RMS lndImp_Sl_snowh                  2.4103E-03            NORMALIZED  8.7984E-02
 RMS lndImp_Sl_t                      1.8861E+00            NORMALIZED  7.2076E-03
 RMS lndImp_Sl_tref                   2.1301E-01            NORMALIZED  8.0407E-04
 RMS lndImp_Sl_u10                    2.7456E-02            NORMALIZED  1.3279E-02

@ekluzek ekluzek self-assigned this Jul 9, 2025
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations testing additions or changes to tests labels Jul 9, 2025
@ekluzek ekluzek added bfb bit-for-bit performance idea or PR to improve performance (e.g. throughput, memory) size: small devops Development Operations to improve development throughput, E.g., adding GitHub Workflows labels Jul 9, 2025
@ekluzek ekluzek changed the base branch from master to b4b-dev July 9, 2025 16:32
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek
Seems reasonable. This does not affect the rest of aux_clm, so testing is fine, right? Did John Dennis review your changes?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jul 9, 2025

@ekluzek Seems reasonable. This does not affect the rest of aux_clm, so testing is fine, right? Did John Dennis review your changes?

Good questions @slevis-lmwg. Yes, there isn't a way for it to affect aux_clm. John gave me the list to run and PE layout sizes, but I don't think he would need to see these details. But, that does remind me that I need to push a change to some performance timers from a different branch. So I'll do that before merging this in.

@ekluzek ekluzek merged commit 7774316 into ESCOMP:b4b-dev Jul 9, 2025
4 checks passed
@ekluzek ekluzek deleted the add_decompinit_testlist branch July 9, 2025 19:49
./xmlchange CLM_CONFIGURATION="nwp"

# Turn cpl history off
./xmlchagne HIST_OPTION="never"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes do change answers, I didn't catch this when I pushed this.

SMS_D_Ln1.f10_f10_mg37.I2000Clm50BgcCropQianRs.derecho_intel.clm-run_self_tests.GC.ctsm5361erikb4bdelist

For this type of test it doesn't matter though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit devops Development Operations to improve development throughput, E.g., adding GitHub Workflows enhancement new capability or improved behavior of existing capability performance idea or PR to improve performance (e.g. throughput, memory) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations size: small testing additions or changes to tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add some PE layout test sizes for some resolutions to facilitate testing decompInit time testing for different problem sizes / task counts

2 participants