-
Notifications
You must be signed in to change notification settings - Fork 341
Add decomp_init testlist and some extra PE layouts for some grids #3315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… with faster time-step
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekluzek
Seems reasonable. This does not affect the rest of aux_clm, so testing is fine, right? Did John Dennis review your changes?
Good questions @slevis-lmwg. Yes, there isn't a way for it to affect aux_clm. John gave me the list to run and PE layout sizes, but I don't think he would need to see these details. But, that does remind me that I need to push a change to some performance timers from a different branch. So I'll do that before merging this in. |
| ./xmlchange CLM_CONFIGURATION="nwp" | ||
|
|
||
| # Turn cpl history off | ||
| ./xmlchagne HIST_OPTION="never" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes do change answers, I didn't catch this when I pushed this.
SMS_D_Ln1.f10_f10_mg37.I2000Clm50BgcCropQianRs.derecho_intel.clm-run_self_tests.GC.ctsm5361erikb4bdelist
For this type of test it doesn't matter though.
Description of changes
Add a new testlist decomp_init and add some extra PE layouts for: ne120 and mpasa15
Specific notes
Contributors other than yourself, if any: John Dennis
CTSM Issues Fixed (include github issue #):
Fixes #3312
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)?
Allows ne120 and mpas15 grids to have additional PE layout "sizes": XL, L, M, S, XS for ne120, and L, S, XS for mpasa15
Does this create a need to change or add documentation? Did you do so? No n/a
Testing performed, if any: ran decomp_init testlist
IMPORTANT NOTE: This DOES CHANGE ANSWERS for the one self-test.
I should have caught this and as such shouldn't have merged to b4b-dev.
But, this self-test is a different beast and changes to answers there don't really matter.