Skip to content

Conversation

@ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 26, 2025

Description of changes

By default read in the cmip7 c13/c14 stream files rather than the previous cmip6 ones. Read in the cmip6 ones if CLM_CMIP_ERA=cmip6 and use_c13/use_c14 are on.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? Yes (only when use_c13/use_c14 is on)

Any User Interface Changes (namelist or namelist defaults changes)?
By default read in cmip7 streams files for use_c13/use_c14
Only read in older CMIP6 timeseries files for use_c13/use_c14 if CLM_CMIP_ERA=cmip6

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: Running standard testing

rgknox and others added 30 commits July 24, 2025 11:06
…tream

docs-build-and-deploy: Only run on upstream
…e for CTSM, this compiles with intel on Derecho
…e method a bit, so that varnames and name aren't sent in, also have to make sdat public, so that the dshr_fldbun_getFldPtr method can use it's internal components
…ilename was incorrect as well as a typo for C13 in the Advance and Interp routines
…n be used easier in the code, this increases memory, but matches the rest of CTSM better and isolates the handling of the grid for the C14 data which makes it easier for the grid to change, this is a prestep to moving to streams as this is how streams works
…mfile

set_paramfile: Allow simply setting all of a parameter to a single value
@ekluzek ekluzek added this to the cesm3_0_beta08 milestone Nov 26, 2025
@ekluzek ekluzek self-assigned this Nov 26, 2025
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science non-bfb Changes answers (incl. adding tests) labels Nov 26, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Nov 26, 2025
@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Nov 26, 2025
@ekluzek ekluzek moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to In progress - master in CTSM: Upcoming tags Nov 26, 2025
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 27, 2025

Fails I see in testing on Derecho:

Fail at runtime (in the C14 stream Advance, having trouble finding the current VM:

ERP_D_Ld10_P64x2.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_decStart (NLCOMP RUN)
ERP_D_Ld10_P64x2.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_decStart--clm-matrixcnOn_ignore_warnings (NLCOMP RUN)
ERP_P64x2_D_Ld5.f10_f10_mg37.I1850Clm45BgcCru.derecho_intel.clm-ciso    (NLCOMP RUN)
ERP_P64x2_D_Ld5.f10_f10_mg37.I1850Clm50Bgc.derecho_intel.clm-ciso       (NLCOMP RUN)
ERP_P64x2_D_Ld5.f10_f10_mg37.I1850Clm50Bgc.derecho_intel.clm-ciso--clm-matrixcnOn_ignore_warnings       (NLCOMP RUN)

Fail with the restart comparison: (for C13 variables)

ERP_D_Ld9.ne30pg3_t232.IHistClm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningModeLDust (NLCOMP COMPARE_base_rest BASELINE)
ERS_D_Ld5.f10_f10_mg37.IHistClm50BgcQian.derecho_intel.clm-ciso_bombspike1963DecStart   (NLCOMP COMPARE_base_rest BASELINE)
ERS_D_Ld5.f10_f10_mg37.IHistClm50BgcQian.derecho_intel.clm-ciso_bombspike1963DecStart--clm-matrixcnOn_ignore_warnings   (NLCOMP COMPARE_base_rest BASELINE)

I think the first group may be a problem in needing more memory? Since these are ERP tests it will do one run at P32x1 and that might be too few tasks. I'll try these same tests at P128x1 and P128x2 (which I suspect won't work because of too many processors). If the last doesn't work I'll try something like P200x2.

On the second set, it's a clue that it's only failing for C13. So there must be something different between C13 and C14. I also wonder about the order that things are done including initialization, and possibly there needs to be an adjustment as to when these things happen. I can compare to other streams to get some clues.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 27, 2025

Actually I see a note in clm_driver, that streams aren't threadsafe. So likely what needs to happen is to lift the streams handling out of Photosynthesis to a higher level in clm_driver. This could be done on b4b-dev.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 1, 2025

OK, moving the C13/C14Streams calls to the clm_driver outside of openMP thread loops fixes one problem. And there was a missing Advance in C13Streams that fixes the other. I'll bring these in on b4b-dev and then merge it in here to resolve the final issues here.

@ekluzek ekluzek changed the title Use the CMIP7 Carbon Isotope streams files by default post5.4.000: Use the CMIP7 Carbon Isotope streams files by default Dec 1, 2025
ekluzek added a commit to ekluzek/CTSM that referenced this pull request Dec 1, 2025
…apalgo to none, when meshfile for c14 is none, and add the missing Advance call to C13Streams that caused problems in PR ESCOMP#3634 where cmip7 Ciso is used
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability non-bfb Changes answers (incl. adding tests) science Enhancement to or bug impacting science

Projects

Status: In progress - master
Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants