-
Notifications
You must be signed in to change notification settings - Fork 341
post5.4.000: Use the CMIP7 Carbon Isotope streams files by default #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: post-5.4
Are you sure you want to change the base?
Conversation
b4b-dev merge 2025-10-16
Merge ctsm5.3.080 into b4b-dev
…tream docs-build-and-deploy: Only run on upstream
…e for CTSM, this compiles with intel on Derecho
… in the local object
…into carbon_isotopes_in_streams
… CTSM stream base type
…ve memory when appropriate
…e method a bit, so that varnames and name aren't sent in, also have to make sdat public, so that the dshr_fldbun_getFldPtr method can use it's internal components
…s for C13/C14 timeseries handling
…ilename was incorrect as well as a typo for C13 in the Advance and Interp routines
…n be used easier in the code, this increases memory, but matches the rest of CTSM better and isolates the handling of the grid for the C14 data which makes it easier for the grid to change, this is a prestep to moving to streams as this is how streams works
…mfile set_paramfile: Allow simply setting all of a parameter to a single value
…into carbon_isotopes_in_streams
…til we can change answers
alpha-ctsm5.4.CMIP7.19.ctsm5.3.082: Fix LII2 COMPARE_base_no_interp failures
Carbon isotopes in streams
…4b_changes_to_ctsm5.4 Conflicts: bld/unit_testers/build-namelist_test.pl
…if the file wasn't found use the cmip6 version approach
|
Fails I see in testing on Derecho: Fail at runtime (in the C14 stream Advance, having trouble finding the current VM: Fail with the restart comparison: (for C13 variables) I think the first group may be a problem in needing more memory? Since these are ERP tests it will do one run at P32x1 and that might be too few tasks. I'll try these same tests at P128x1 and P128x2 (which I suspect won't work because of too many processors). If the last doesn't work I'll try something like P200x2. On the second set, it's a clue that it's only failing for C13. So there must be something different between C13 and C14. I also wonder about the order that things are done including initialization, and possibly there needs to be an adjustment as to when these things happen. I can compare to other streams to get some clues. |
|
Actually I see a note in clm_driver, that streams aren't threadsafe. So likely what needs to happen is to lift the streams handling out of Photosynthesis to a higher level in clm_driver. This could be done on b4b-dev. |
|
OK, moving the C13/C14Streams calls to the clm_driver outside of openMP thread loops fixes one problem. And there was a missing Advance in C13Streams that fixes the other. I'll bring these in on b4b-dev and then merge it in here to resolve the final issues here. |
…apalgo to none, when meshfile for c14 is none, and add the missing Advance call to C13Streams that caused problems in PR ESCOMP#3634 where cmip7 Ciso is used
Description of changes
By default read in the cmip7 c13/c14 stream files rather than the previous cmip6 ones. Read in the cmip6 ones if CLM_CMIP_ERA=cmip6 and use_c13/use_c14 are on.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Yes (only when use_c13/use_c14 is on)
Any User Interface Changes (namelist or namelist defaults changes)?
By default read in cmip7 streams files for use_c13/use_c14
Only read in older CMIP6 timeseries files for use_c13/use_c14 if CLM_CMIP_ERA=cmip6
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: Running standard testing