Skip to content

Compiler fixes #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Compiler fixes #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a81d290
CMakePresets: Must be RelWithDebInfo, not ReleaseWithDebInfo
Ghabry Apr 14, 2025
988417d
Vita: Disable optimize-sibling-calls optimisation
Ghabry Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,10 @@ endif()
# Shared by homebrew platforms
if(NINTENDO_3DS OR NINTENDO_WII OR NINTENDO_WIIU OR NINTENDO_WIIU OR NINTENDO_SWITCH OR VITA)
target_compile_options(${PROJECT_NAME} PUBLIC -fno-exceptions -fno-rtti)
if(VITA)
# This optimisation is unstable on Vita (crashes at the end of MainLoop)
target_compile_options(${PROJECT_NAME} PUBLIC -fno-optimize-sibling-calls)
endif()
set(CMAKE_DL_LIBS "") # hack4icu!
set(PLAYER_ENABLE_TESTS OFF)
option(PLAYER_VERSIONED_PACKAGES "Create zip packages with versioned name (for internal use)" ON)
Expand Down
2 changes: 1 addition & 1 deletion builds/cmake/CMakePresetsBase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"displayName": "build RelWithDebInfo",
"hidden": true,
"cacheVariables": {
"CMAKE_BUILD_TYPE": "ReleaseWithDebInfo"
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
{
Expand Down
Loading