[andino_firmware] Fix all pending pre-commit checks and style linting issues (#329)

Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>

Author: jballoffet

andino_firmware/CPPLINT.cfg

@@ -1,2 +1,3 @@
 set noparent
-filter=-whitespace/line_length
+filter=-runtime/int,-whitespace/empty_if_body,-build/include_order
+linelength=120

andino_firmware/src/app/app.cpp

@@ -64,6 +64,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "andino/app/app.h"
 
+#include <stdio.h>
+
 #include <Adafruit_BNO055.h>
 #include <Adafruit_Sensor.h>
 #include <Arduino.h>
@@ -239,7 +241,7 @@ void App::cmd_set_pid_tuning_gains_cb(void* context, int argc, char** argv) {
   int pid_args[kSizePidArgs]{0, 0, 0, 0};
 
   // Example: "u 30:20:10:50".
-  strcpy(arg, argv[1]);
+  snprintf(arg, sizeof(arg), "%s", argv[1]);
   char* p = arg;
   while ((str = strtok_r(p, ":", &p)) != NULL && i < kSizePidArgs) {
     pid_args[i] = atoi(str);

andino_firmware/src/app/shell.cpp

@@ -29,6 +29,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "andino/app/shell.h"
 
+#include <stdio.h>
 #include <string.h>
 
 namespace andino {
@@ -47,7 +48,7 @@ void Shell::register_command(const char* name, CommandCallback callback, void* c
   }
 
   Command command;
-  strcpy(command.name, name);
+  snprintf(command.name, sizeof(command.name), "%s", name);
   command.callback = callback;
   command.context = context;
   commands_[commands_count_++] = command;
@@ -84,10 +85,11 @@ void Shell::process_input() {
 void Shell::parse_message() {
   char* argv[kCommandArgMax];
   int argc = 0;
+  char* saveptr = nullptr;
 
-  argv[argc] = strtok(message_buffer_, " ");
+  argv[argc] = strtok_r(message_buffer_, " ", &saveptr);
   while (argv[argc] != NULL && argc < (kCommandArgMax - 1)) {
-    argv[++argc] = strtok(NULL, " ");
+    argv[++argc] = strtok_r(NULL, " ", &saveptr);
   }
 
   execute_callback(argc, argv);